Fix version propagation in release builds #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes version propagation in release builds by injecting the application version at build time through Vite's define mechanism, replacing the previous runtime approach of reading package.json. The changes also include dependency updates for various packages.
Key Changes:
- Replaced runtime file reading with build-time version injection via Vite configuration
- Updated version references across CLI, AppServer, and Layout components to use injected
__APP_VERSION__ - Modified CI/CD workflow to run a dry-run semantic release to determine version before building
- Updated multiple dependencies to latest versions
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
vite.config.ts |
Added __APP_VERSION__ definition that injects version from APP_VERSION env var or package.json |
src/types/build-env.d.ts |
Added type declaration for __APP_VERSION__ global constant |
src/web/components/Layout.tsx |
Removed runtime file reading logic; now uses injected __APP_VERSION__ constant |
src/cli/index.ts |
Replaced packageJson.version imports with __APP_VERSION__ constant |
src/app/AppServer.ts |
Replaced packageJson.version imports with __APP_VERSION__ constant |
.github/workflows/release.yml |
Added dry-run semantic release step to determine version before build |
package.json |
Updated dependencies to newer versions |
package-lock.json |
Lockfile updates corresponding to dependency changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arabold
force-pushed
the
fix/264-version-info
branch
2 times, most recently
from
58572fa to
8454cf6
Compare
- Updated various dependencies in package.json to their latest versions. - Replaced direct import of package.json for versioning with build-time injected variable __APP_VERSION__ in AppServer.ts, index.ts, and Layout.tsx. - Added declaration for __APP_VERSION__ in build-env.d.ts. - Modified vite.config.ts to inject __APP_VERSION__ from environment variables during the build process. Closes Version number isn't properly propagated in release version Fixes #264
arabold
force-pushed
the
fix/264-version-info
branch
from
8454cf6 to
6f36709
Compare
|
🎉 This PR is included in version 1.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inject the correct application version at build time to ensure the version number is properly displayed in the Web UI and when running the server. Update dependencies and modify the build configuration to support this change.
Fixes #264