-
Notifications
You must be signed in to change notification settings - Fork 5
chore: devnet to testnet #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…licts Prevents ambiguity in gateway sandboxed subdomains where 43-character ARNS names could be confused with Arweave addresses. Valid lengths remain 1-42 and 44-51 characters.
#440) …licts Prevents ambiguity in gateway sandboxed subdomains where 43-character ARNS names could be confused with Arweave addresses. Valid lengths remain 1-42 and 44-51 characters. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Names that are exactly 43 characters are now rejected to avoid conflicts with Arweave-style addresses in sandboxed subdomains; existing acceptance for 1–42 and 44+ character names remains unchanged. * **Tests** * Added comprehensive tests validating rejection of 43-character names and boundary/edge cases (42, 44+, hyphens, mixed alphanumeric, numeric-only, uppercase) to ensure consistent behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
==========================================
+ Coverage 91.34% 91.36% +0.01%
==========================================
Files 10 10
Lines 3213 3218 +5
==========================================
+ Hits 2935 2940 +5
Misses 278 278 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.