Skip to content

Conversation

@dtfiedler
Copy link
Collaborator

No description provided.

vilenarios and others added 8 commits October 28, 2025 12:33
…licts

  Prevents ambiguity in gateway sandboxed subdomains where 43-character ARNS
  names could be confused with Arweave addresses. Valid lengths remain 1-42
  and 44-51 characters.
#440)

…licts

Prevents ambiguity in gateway sandboxed subdomains where 43-character
ARNS
names could be confused with Arweave addresses. Valid lengths remain
1-42
  and 44-51 characters.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Names that are exactly 43 characters are now rejected to avoid
conflicts with Arweave-style addresses in sandboxed subdomains; existing
acceptance for 1–42 and 44+ character names remains unchanged.

* **Tests**
* Added comprehensive tests validating rejection of 43-character names
and boundary/edge cases (42, 44+, hyphens, mixed alphanumeric,
numeric-only, uppercase) to ensure consistent behavior.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@coderabbitai
Copy link

coderabbitai bot commented Oct 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.36%. Comparing base (d23e713) to head (bb71487).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
+ Coverage   91.34%   91.36%   +0.01%     
==========================================
  Files          10       10              
  Lines        3213     3218       +5     
==========================================
+ Hits         2935     2940       +5     
  Misses        278      278              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dtfiedler dtfiedler merged commit 47b0e87 into main Oct 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants