refactor(misconf): move common logic to base value and simplify typed values #9986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the handling of IaC values in the
iac/typespackage. A new genericBaseValuestructure is introduced, serving as a universal container for storing a value along with its metadata. It centralizes all core logic for working with values, including JSON serialization and Rego conversion.Typed values (
StringValue,BoolValue,TimeValue, etc.) remain and can override behavior, for exampleTimeValue.ToRego, as well as provide domain-specific methods likeStringValue.StartsWithorStringValue.Contains.Constructors are preserved for convenient and safe creation of values, while invariants such as
Default,Explicit, andUnresolvableare centrally enforced throughBaseValue.Checklist