Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: add Gitlab job that uses a container with trivy #823

Merged

Conversation

TriplEight
Copy link
Contributor

Hi, I was adding trivy instead of a broken built in GitLab for my use case clair, and made it work a simpler way than you describe it in README. This job takes ~15 sec given the image is cached.
Please correct me if I'm wrong somewhere.

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #823 (54fdc43) into main (a00d719) will not change coverage.
The diff coverage is 95.83%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #823   +/-   ##
=======================================
  Coverage   68.50%   68.50%           
=======================================
  Files          57       58    +1     
  Lines        2210     2210           
=======================================
  Hits         1514     1514           
  Misses        564      564           
  Partials      132      132           
Impacted Files Coverage Δ
internal/app.go 98.38% <ø> (-0.10%) ⬇️
pkg/detector/ospkg/alpine/alpine.go 94.73% <ø> (ø)
pkg/github/github.go 58.00% <0.00%> (ø)
pkg/detector/library/python/advisory.go 100.00% <100.00%> (ø)
pkg/detector/library/python/compare.go 100.00% <100.00%> (ø)
pkg/detector/ospkg/redhat/redhat.go 93.54% <100.00%> (+0.21%) ⬆️
pkg/vulnerability/vulnerability.go 76.69% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ed03a8...54fdc43. Read the comment docs.

@knqyf263
Copy link
Collaborator

Thanks for your contribution. We already have a document regarding GitLab CI, but do you prefer using a container image?
https://github.com/aquasecurity/trivy#gitlab-ci

@TriplEight
Copy link
Contributor Author

TriplEight commented Jan 27, 2021

Thanks for your contribution. We already have a document regarding GitLab CI, but do you prefer using a container image?
https://github.com/aquasecurity/trivy#gitlab-ci

Yeah, that's why I've added it right under the existing one (can substitute if you find it better). My setup is faster, it doesn't use slow dind and doesn't download the binary on every run.

@TriplEight
Copy link
Contributor Author

Are any more changes required here?

@knqyf263 knqyf263 merged commit b0fe439 into aquasecurity:main Feb 8, 2021
@knqyf263
Copy link
Collaborator

knqyf263 commented Feb 8, 2021

Sorry I was at a company-wide event last week. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants