Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nodeSelector, affinity and tolerations to helm chart #803

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

ctolon22
Copy link
Contributor

@ctolon22 ctolon22 commented Jan 8, 2021

Fixes #800

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #803 (384e3b9) into main (a00d719) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #803      +/-   ##
==========================================
- Coverage   68.50%   68.39%   -0.12%     
==========================================
  Files          57       57              
  Lines        2210     2202       -8     
==========================================
- Hits         1514     1506       -8     
  Misses        564      564              
  Partials      132      132              
Impacted Files Coverage Δ
internal/app.go 98.38% <ø> (-0.10%) ⬇️
pkg/detector/ospkg/redhat/redhat.go 93.54% <100.00%> (+0.21%) ⬆️
pkg/vulnerability/vulnerability.go 76.69% <100.00%> (+0.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b27862...384e3b9. Read the comment docs.

Copy link
Contributor

@czunker czunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ctolon22

Please also update the README for the chart and bump the chart version.

Copy link
Contributor

@czunker czunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@knqyf263 knqyf263 merged commit 6b29bf1 into aquasecurity:main Jan 11, 2021
@knqyf263
Copy link
Collaborator

Thank you so much!

liamg pushed a commit that referenced this pull request Jun 7, 2022
* Added nodeSelector, affinity and tolerations to helm chart

* Updated helm README.md and bumped version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add nodeSelector and tolerations in helm chart
4 participants