-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: combine trivy.dev into trivy docs #7884
Conversation
Co-authored-by: simar7 <1254783+simar7@users.noreply.github.com>
I think this is ready for review now. I might change the quotes abit, and possibly copy the users avatars to serve locally, but otherwise it's ready (of course, we will iterate on the content over time) |
I missed updating this workflow since it's name didn't follow the other docs workflow names. besides fixing the build. should I rename this from |
the job succeeds now. just so confirm - since it's missing the |
It depends on how we categorize this workflow. If you consider this workflow is more like mkdocs things rather than testing, I'm totally fine with the change. I just explained the reason behind that. |
Yes, that is the intention. I don't remember, but we probably used
We can remove |
Co-authored-by: simar7 <1254783+simar7@users.noreply.github.com>
Thanks, I've identified a work around but looking for a more elegant fix |
as part of this change, we will also need to redirect
I thought that we fall into the GH Actions category but it appears we aren't. In this case, I will add the trivy.dev as custom domain in the UI, which will create the CNAME file in the docs branch, and |
fixed |
Description
Today we have https://trivy.dev as the homepage for Trivy, and https://aquasecurity.github.io/trivy as the documentation site. This is suboptimal because:
This PR takes the theme and some elements from trivy.dev and adds a new homepage to the current docs site, so that the current docs site can become the one place with all of Trivy's content.
Additionally, there are some content changes (especially in getting started) in the docs to make it more suitable for the new structure.
This is to kick-off the new website motion, in the future I suspect we will do some more revisions on the docs sections, and also add more content to the homepage which currently is minimal.
since this is a large PR, best to process it by commits.