Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redis cache backend configuration options #784

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Dec 24, 2020

You can now specify redis as caching as backend.
The default is still the filesystem.

In case redis is added as caching backend, the cache-dir is still
used for the vulnerability database.

Fixes #781

Signed-off-by: Christian Zunker christian.zunker@codecentric.cloud

You can now specify redis as caching as backend.
The default is still the filesystem.

In case redis is added as caching backend, the cache-dir is still
used for the vulnerability database.

Fixes aquasecurity#781

Signed-off-by: Christian Zunker <christian.zunker@codecentric.cloud>
@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #784 (e4441b9) into main (a00d719) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #784   +/-   ##
=======================================
  Coverage   68.50%   68.50%           
=======================================
  Files          57       57           
  Lines        2210     2210           
=======================================
  Hits         1514     1514           
  Misses        564      564           
  Partials      132      132           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e08ae8d...e4441b9. Read the comment docs.

@knqyf263
Copy link
Collaborator

I meant redis.enabled was necessary if we add redis chart to the dependency. In this case, it might no be needed, but I'll follow @danielpacak's thought.

@knqyf263 knqyf263 requested a review from danielpacak December 25, 2020 14:28
@Hokwang
Copy link

Hokwang commented Dec 26, 2020

This is what I want!

Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 merged commit b9b84cd into aquasecurity:main Jan 4, 2021
liamg pushed a commit that referenced this pull request Jun 7, 2022
You can now specify redis as caching as backend.
The default is still the filesystem.

In case redis is added as caching backend, the cache-dir is still
used for the vulnerability database.

Fixes #781

Signed-off-by: Christian Zunker <christian.zunker@codecentric.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add redis support in the Helm chart
4 participants