-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(redhat): include arch in PURL qualifiers #7654
Conversation
Signed-off-by: knqyf263 <knqyf263@gmail.com>
packageurl.Qualifiers{ | ||
{ | ||
Key: "arch", | ||
Value: pkg.Arch, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure - does the Arch
field always exist?
I'm worried about the case when pkg.Arch
is missing. Then we'll see a case like pkg:rpm/redhat/socat@1.7.3.2-2.el7?arch="
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it doesn't happen, but I added a check just in case.
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@DmitriyLewen It passed tests after some retries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@aqua-bot backport release/v0.56 |
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Backport PR created: #7702 |
Description
If arch is not included in the PURL, the CycloneDX BOM-Ref will conflict and the UUID will be used.
Before
After
Related PRs
Checklist