feat(cli): error out when ignore file cannot be found

[sgaist]

Description

This PR introduces a check for --ignorefile so that if the file is missing it will error out.
This does not happen for the default ignore file as is currently already the case.

Related issues

• Close feat(misconf): Improve logging experience when --ignorefile not found #7093

Checklist

• I've read the guidelines for contributing to this repository.
• I've followed the conventions in the PR title.
• I've added tests that prove my fix is effective or that my feature works.
• I've updated the documentation with the relevant information (if needed).
• I've added usage information (if the PR introduces new options)
• I've included a "before" and "after" example to the description (if the PR is a user interface change).

[simar7]

Should we error out or just simply WARN the user that their ignorefile doesn't exist? @knqyf263 WDYT?

[sgaist]

If I may, while a warning might be enough when a user calls trivy explicitly, in an automated context, unless there's some warning detection put in place, it might get missed and thus the scan output will not match expectation.

[knqyf263]

Fair enough. It looks better to return an error.

[knqyf263]

Thanks for your contribution. I left a small comment.

[knqyf263]

This check occurs at the end of scanning. We may want to fail on that at an earlier stage. Something like:

diff --git a/pkg/flag/report_flags.go b/pkg/flag/report_flags.go
index 67d553b65..d69443e89 100644
--- a/pkg/flag/report_flags.go
+++ b/pkg/flag/report_flags.go
@@ -6,6 +6,7 @@ import (

        "github.com/mattn/go-shellwords"
        "github.com/samber/lo"
+       "github.com/spf13/viper"
        "golang.org/x/xerrors"

        dbTypes "github.com/aquasecurity/trivy-db/pkg/types"
@@ -14,6 +15,7 @@ import (
        "github.com/aquasecurity/trivy/pkg/log"
        "github.com/aquasecurity/trivy/pkg/result"
        "github.com/aquasecurity/trivy/pkg/types"
+       "github.com/aquasecurity/trivy/pkg/utils/fsutils"
        xstrings "github.com/aquasecurity/trivy/pkg/x/strings"
 )

@@ -238,6 +240,10 @@ func (f *ReportFlagGroup) ToOptions() (ReportOptions, error) {
                }
        }

+       if viper.IsSet(f.IgnoreFile.ConfigName) && !fsutils.FileExists(f.IgnoreFile.Value()) {
+               return ReportOptions{}, xerrors.Errorf("ignore file not found: %s", f.IgnoreFile.Value())
+       }
+
        return ReportOptions{
                Format:           format,
                ReportFormat:     f.ReportFormat.Value(),

[sgaist]

Even better !

Thanks for improving my viper knowledge

[simar7]

lgtm!