Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added logic to pass config data to aws #4684

Closed

Conversation

r-khurram
Copy link

@r-khurram r-khurram commented Jun 20, 2023

Description

Added logic to pass config-data on to defsec policies and produce results based on those user given input.

Related issues

Related PRs

  • #XXX
  • #YYY

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@r-khurram r-khurram requested a review from knqyf263 as a code owner June 20, 2023 17:08
@CLAassistant
Copy link

CLAassistant commented Jun 20, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Phaedra Solutions seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@r-khurram r-khurram changed the title added logic to pass config data to aws add: added logic to pass config data to aws Jun 20, 2023
@r-khurram r-khurram changed the title add: added logic to pass config data to aws fix: added logic to pass config data to aws Jun 20, 2023
@r-khurram r-khurram changed the title fix: added logic to pass config data to aws fix: added logic to pass config data to aws Jun 20, 2023
@r-khurram r-khurram force-pushed the add-config-data-aws-scanner branch 2 times, most recently from d9fc050 to 8d28261 Compare June 21, 2023 20:45
@simar7 simar7 self-requested a review June 22, 2023 00:13
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tests are failing.

You can run tests locally using mage test:unit and mage test:integration before pushing to save time.

@r-khurram r-khurram force-pushed the add-config-data-aws-scanner branch from 8d28261 to c2c10fa Compare June 25, 2023 12:27
@simar7
Copy link
Member

simar7 commented Jun 27, 2023

@r-khurram Looks like there are merge conflicts now.

@r-khurram r-khurram force-pushed the add-config-data-aws-scanner branch from c2c10fa to 28211f0 Compare June 27, 2023 05:57
@r-khurram
Copy link
Author

@r-khurram Looks like there are merge conflicts now.

Fixed the conflicts

@r-khurram r-khurram force-pushed the add-config-data-aws-scanner branch from 28211f0 to df34252 Compare June 27, 2023 07:07
@r-khurram r-khurram force-pushed the add-config-data-aws-scanner branch from df34252 to 3d9e495 Compare June 27, 2023 08:23
@simar7
Copy link
Member

simar7 commented Jul 1, 2023

Closing in favour of #4745

@simar7 simar7 closed this Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants