Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump Go to 1.19 #2861

Merged
merged 11 commits into from
Sep 14, 2022
Merged

chore: bump Go to 1.19 #2861

merged 11 commits into from
Sep 14, 2022

Conversation

knqyf263
Copy link
Collaborator

Description

Bump Go

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263
chore: bump Go to 1.19
1ee5394 
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263
use go-version-file
44bc042
@knqyf263 knqyf263 requested a review from tonaim September 13, 2022 07:52
@knqyf263 knqyf263 self-assigned this Sep 13, 2022
@knqyf263 knqyf263 marked this pull request as ready for review September 13, 2022 18:25
knqyf263
knqyf263 commented Sep 13, 2022
View reviewed changes
.golangci.yaml
- G204
- G402

linters:
disable-all: true
enable:
- structcheck
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

structcheck, varcheck and deadcode are deprecated. unused is recommended now.

@knqyf263
Copy link
Collaborator Author

@owenrumney @chen-keinan Could either of you review this PR? I just bumped the Go version, but gofmt now tries to format comments as well. Therefore, I needed some tweaks on the comments. Otherwise, golangci-lint complains about it.

@chen-keinan
Copy link
Contributor

@owenrumney @chen-keinan Could either of you review this PR? I just bumped the Go version, but gofmt now tries to format comments as well. Therefore, I needed some tweaks on the comments. Otherwise, golangci-lint complains about it.

LGTM 🚀

@knqyf263
Copy link
Collaborator Author

knqyf263 commented Sep 14, 2022 •
edited
Loading

Thank you @josedonizetti @chen-keinan and @tonaim.
Looks like it requires review from Owen or Liam as they are code owner on pkg/flag. LIam is on vacation, so I'll wait for @owenrumney.

owenrumney
owenrumney approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@owenrumney owenrumney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@knqyf263 knqyf263 merged commit 39f83af into main Sep 14, 2022
@knqyf263 knqyf263 deleted the go119 branch September 14, 2022 08:42
@knqyf263 knqyf263 mentioned this pull request Sep 14, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josedonizetti josedonizetti josedonizetti approved these changes

@owenrumney owenrumney owenrumney approved these changes

@chen-keinan chen-keinan chen-keinan approved these changes

@tonaim tonaim tonaim approved these changes

@liamg liamg Awaiting requested review from liamg

Assignees

@knqyf263 knqyf263

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@knqyf263 @chen-keinan @josedonizetti @owenrumney @tonaim