Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(report): add required fields to the SARIF template #2341

Merged
merged 13 commits into from
Jun 20, 2022
Merged

fix(report): add required fields to the SARIF template #2341

merged 13 commits into from
Jun 20, 2022

Conversation

afdesk
Copy link
Contributor

@afdesk afdesk commented Jun 16, 2022 •
edited
Loading

Description

SARIF template for Github must contain all fields for physicalLocation object.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

DmitriyLewen
DmitriyLewen reviewed Jun 17, 2022
View reviewed changes
@afdesk afdesk marked this pull request as ready for review June 20, 2022 05:41
@afdesk afdesk requested a review from knqyf263 as a code owner June 20, 2022 05:41
@knqyf263 knqyf263 merged commit 6ce9404 into main Jun 20, 2022
@knqyf263 knqyf263 deleted the sarif_improve_uri branch June 20, 2022 10:31
@multani multani mentioned this pull request Feb 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen left review comments

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generalize location field in SARIF output
3 participants
@afdesk @knqyf263 @DmitriyLewen