-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(report): add support for SPDX #2059
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great; thanks for taking the time to implement this feature! I've left a small suggestion for this PR.
pkg/report/spdx/spdx.go
Outdated
) | ||
|
||
const ( | ||
SPDXVersion = "SPDX-2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPDXVersion = "SPDX-2.1" | |
SPDXVersion = "SPDX-2.2" |
The latest version of the SPDX specification is 2.2 😃
docs/docs/sbom/spdx.md
Outdated
"versionInfo": "1.2.12-r0" | ||
} | ||
], | ||
"spdxVersion": "SPDX-2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"spdxVersion": "SPDX-2.1" | |
"spdxVersion": "SPDX-2.2" |
@ShiraCohen33 thanks for bumping the SPDX specification version! 😃 |
docs/docs/sbom/spdx.md
Outdated
<summary>Result</summary> | ||
|
||
``` | ||
$ cat result.spdx | jq . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this JSON?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's a mistake
Co-authored-by: knqyf263 <knqyf263@gmail.com>
Description
Add SPDX format support
Related issues
Checklist