Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(report): add support for SPDX #2059

Merged
merged 21 commits into from
May 2, 2022

Conversation

ShiraCohen33
Copy link
Contributor

@ShiraCohen33 ShiraCohen33 commented Apr 27, 2022

Description

Add SPDX format support

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@seabass-labrax seabass-labrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great; thanks for taking the time to implement this feature! I've left a small suggestion for this PR.

)

const (
SPDXVersion = "SPDX-2.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SPDXVersion = "SPDX-2.1"
SPDXVersion = "SPDX-2.2"

The latest version of the SPDX specification is 2.2 😃

"versionInfo": "1.2.12-r0"
}
],
"spdxVersion": "SPDX-2.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"spdxVersion": "SPDX-2.1"
"spdxVersion": "SPDX-2.2"

@seabass-labrax
Copy link
Contributor

@ShiraCohen33 thanks for bumping the SPDX specification version! 😃

<summary>Result</summary>

```
$ cat result.spdx | jq .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this JSON?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's a mistake

@knqyf263 knqyf263 merged commit 6601d29 into aquasecurity:main May 2, 2022
@knqyf263 knqyf263 added this to the v0.28.0 milestone May 10, 2022
liamg pushed a commit that referenced this pull request Jun 7, 2022
Co-authored-by: knqyf263 <knqyf263@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants