Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(option): hide false warning about remote options #1865

Merged
merged 2 commits into from
Mar 22, 2022
Merged

fix(option): hide false warning about remote options #1865

merged 2 commits into from
Mar 22, 2022

Conversation

afdesk
Copy link
Contributor

@afdesk afdesk commented Mar 22, 2022 •
edited
Loading

Description

tokenHeader flag was initialized by default value (not empty), so warning message was always shown.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@afdesk afdesk requested a review from knqyf263 March 22, 2022 14:07
@knqyf263 knqyf263 merged commit df80fd3 into main Mar 22, 2022
@knqyf263 knqyf263 deleted the fix_warning branch March 22, 2022 14:33
ankk13 pushed a commit to ankk13/trivy that referenced this pull request Mar 28, 2022
@afdesk @ankk13
fix(option): hide false warning about remote options (aquasecurity#1865)
4b498a0
liamg pushed a commit that referenced this pull request Jun 7, 2022
@afdesk
fix(option): hide false warning about remote options (#1865)
7326709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afdesk @knqyf263