Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dbRepositoryUsername and dbRepositoryPassword for dbReposit… #1657

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

juergen-fast
Copy link
Contributor

Description

Add the configs dbRepositoryUsername and dbRepositoryPassword to allow authentication for the dbRepository.
This configuration sets the environment variables TRIVY_USERNAME and TRIVY_PASSWORD in the scan-vulnerabilityreport-pods.

Checklist

@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023

CLA assistant check
All committers have signed the CLA.

@chen-keinan
Copy link
Contributor

@juergen-fast thank you for the contribution I have one comment: do you think it worthwhile to add this setting also for built-in server config somewhere here ? so it will have support for client/server users

Copy link
Contributor

@chen-keinan chen-keinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its ok to add this comment (#nosec G101) next to user / password config to overcome lint issue :
keyTrivyDBRepositoryPassword = "trivy.dbRepositoryPassword" // #nosec G101

@juergen-fast
Copy link
Contributor Author

@juergen-fast thank you for the contribution I have one comment: do you think it worthwhile to add this setting also for built-in server config somewhere here ? so it will have support for client/server users

My changes based on the githubToken-Code. I think there is no need for built-in server because in this case you have the property serverUser and serverPassword in the trivy secret here

@chen-keinan
Copy link
Contributor

@juergen-fast run mage generate:docs to update helm docs

@chen-keinan
Copy link
Contributor

@juergen-fast you'll need to update plugin tests with new EnvVar

@chen-keinan
Copy link
Contributor

@juergen-fast any update on this?

@juergen-fast
Copy link
Contributor Author

@juergen-fast any update on this?

I tried adding the new EnvVar but the tests still fail. I don't know how to fix them, sry

@chen-keinan
Copy link
Contributor

@juergen-fast I'll have a look

Signed-off-by: chenk <hen.keinan@gmail.com>
@chen-keinan
Copy link
Contributor

@juergen-fast lgtm 🚀 thank you for the contribution

@chen-keinan chen-keinan merged commit 1ecf6a0 into aquasecurity:main Dec 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants