-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dbRepositoryUsername and dbRepositoryPassword for dbReposit… #1657
Conversation
…ory authentication
@juergen-fast thank you for the contribution I have one comment: do you think it worthwhile to add this setting also for built-in server config somewhere here ? so it will have support for client/server users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its ok to add this comment (#nosec G101
) next to user / password config to overcome lint issue :
keyTrivyDBRepositoryPassword = "trivy.dbRepositoryPassword" // #nosec G101
My changes based on the githubToken-Code. I think there is no need for built-in server because in this case you have the property serverUser and serverPassword in the trivy secret here |
@juergen-fast run |
@juergen-fast you'll need to update plugin tests with new EnvVar |
@juergen-fast any update on this? |
I tried adding the new EnvVar but the tests still fail. I don't know how to fix them, sry |
@juergen-fast I'll have a look |
Signed-off-by: chenk <hen.keinan@gmail.com>
@juergen-fast lgtm 🚀 thank you for the contribution |
Description
Add the configs dbRepositoryUsername and dbRepositoryPassword to allow authentication for the dbRepository.
This configuration sets the environment variables TRIVY_USERNAME and TRIVY_PASSWORD in the scan-vulnerabilityreport-pods.
Checklist