fix(build): cyclic dependency in makefile #4262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geyslan
force-pushed
the
makefile-fix
branch
2 times, most recently
from
4cdeb4c
to
b422156
Compare
geyslan
changed the title
$(GOENV_MK) is a body level include, so using it as a prerequisite and as a target dependency caused a cyclic dependency. Use .eval_goenv rule (and placeholder file) to evaluate variables to be stored in goenv.mk and use the placeholder as a prerequisite for the targets that need the goenv.mk content.
geyslan
added a commit
to geyslan/tracee
that referenced
this pull request
Aug 27, 2024
geyslan
added a commit
that referenced
this pull request
Aug 27, 2024
rscampos
pushed a commit
to rscampos/tracee
that referenced
this pull request
Aug 27, 2024
commit: bf701bd (main), cherry-pick
rscampos
pushed a commit
that referenced
this pull request
Aug 27, 2024
commit: bf701bd (main), cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
a17f7ef fix(build): cyclic dependency in makefile
2. Explain how to test it
3. Other comments