Refactor: Optimize GetCgroupPath() memory utilization #4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GetCgroupPath function previously used recursion for directory traversal, which could consume excessive memory for deep directory structures. This commit refactors the function to use an iterative approach, reducing memory usage and improving performance. Additionally, the comments and error handling in the function have been updated for clarity and consistency.
yanivagman
force-pushed
the
improve_get_cgroup_path_mem
branch
from
15d3624
to
0bc948f
Compare
geyslan
approved these changes
May 29, 2024
| entryPath := filepath.Join(currentDir, entry.Name()) | ||
|
|
||
| // Check if the entry matches the subPath (if provided) | ||
| if strings.HasSuffix(entryPath, subPath) { |
There was a problem hiding this comment.
Perhaps a single subPath check short circuit avoiding the next inner HasSuffix check against the two lenghts len(s) >= len(suffix). Probably negligible, anyway.
Suggested change
| if strings.HasSuffix(entryPath, subPath) { | |
| if subPath != "" && strings.HasSuffix(entryPath, subPath) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
The GetCgroupPath function previously used recursion for directory traversal, which could consume excessive memory for deep directory structures. This commit refactors the function to use an iterative approach, reducing memory usage and improving performance. Additionally, the comments and error handling in the function have been updated for clarity and consistency.
2. Explain how to test it
3. Other comments