fix(proctree): limit tree memory usage and reduce it #4058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add limitation to the amount of logged objects in the changelog. This should help in reducing the chance of memory leakage.
The current proces tree takes a lot of memory (~150MB from calculation). However, it is a new feature and not all of its info has high chance to be used. For now, it was decided to not save the interpreter and interp information for processes until it was proven to be needed. This should reduce the process tree size by at least 60MB (but will probably reduce more than that).
File paths are created by concatting the dentries names from the root to the file, and concattign the file name in the end. Although each dentry and file name has max length, the entire path has none. To avoid memorly leakage caused by saving file paths, introduce a limit to the save path length.
AlonZivony
force-pushed
the
feature/bounded-memory-changelog
branch
from
41ce163
to
03d6822
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
This PR add limitation on the changelog objects sizes, and reduces drastically the memory usage of the tree by not saving the interpreter and interp information in the tree.
This should reduce the chance for memory leakage.
By rough calculation, before the PR the process tree would take around 150MB of memory on average.
After this change, it should be reduced by at least 60MB on average.
2. Explain how to test it
3. Other comments