--help flag parsing
#3393
Merged
--help flag parsing
#3393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josedonizetti
approved these changes
Aug 16, 2023
The --help flag was not being parsed correctly, i.e. `sudo ./dist/tracee --help whatever` was not showing the help message. This commit fixes the issue by using the `--help` flag as a boolean flag and leaving the hard work to cobra.
geyslan
force-pushed
the
3372-help-flag
branch
from
0611b6d
to
27bee74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #3372
1. Explain what the PR does
0611b6d chore(cmd): refactor config flag
add4054 fix(cmd): --help flag parsing
fix(cmd): --help flag parsing
2. Explain how to test it
sudo ./dist/tracee --helpsudo ./dist/tracee --help --scope comm=whosudo ./dist/tracee --scope comm=who --helpExpected failing:
sudo ./dist/tracee --scope --helpsudo ./dist/tracee --help whatever3. Other comments