fix(events): fix slice out of bounds in hidden_kernel_module (#4379)

aquasecurity · Nov 11, 2024 · 1fdb3f0 · 1fdb3f0
1 parent 79cfd5f
commit 1fdb3f0
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pkg/events/derive/hidden_kernel_module.go b/pkg/events/derive/hidden_kernel_module.go
@@ -177,15 +177,17 @@ func extractFromEvent(args []trace.Argument, address uint64) []interface{} {
 	}
 
 	// Parse module srcversion if possible
-	var srcversion string
+	srcversion := ""
 	srcversionBytes, err := parse.ArgVal[[]byte](args, "srcversion")
 	if err != nil {
-		srcversion = ""
 		// Don't fail hard, submit it without a srcversion!
 		logger.Debugw("Failed extracting hidden module srcversion")
 	} else {
 		// Remove the trailing terminating characters
-		srcversion = string(srcversionBytes[:bytes.IndexByte(srcversionBytes[:], 0)])
+		index := bytes.IndexByte(srcversionBytes[:], 0)
+		if index > 0 {
+			srcversion = string(srcversionBytes[:index])
+		}
 	}
 
 	addrHex := fmt.Sprintf("0x%x", address)