Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integration): Add scaffold for running integration tests #73

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

danielpacak
Copy link
Contributor

@danielpacak danielpacak commented Jun 30, 2020

In this PR I'd like to introduce:

The Gomega has great support for Asynch Assertions, which is even more relevant for integration testing reconciliation loops, e.g. asserting on desired vs expected / actual state of the world

Signed-off-by: Daniel Pacak pacak.daniel@gmail.com

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #73 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #73   +/-   ##
=======================================
  Coverage   11.35%   11.35%           
=======================================
  Files          27       27           
  Lines        1295     1295           
=======================================
  Hits          147      147           
  Misses       1141     1141           
  Partials        7        7           
Impacted Files Coverage Δ
pkg/polaris/scanner.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0ad1ad...9f4e1d6. Read the comment docs.

@danielpacak danielpacak force-pushed the integration_tests_scaffold branch 4 times, most recently from 57cc07e to 0f0ff57 Compare June 30, 2020 15:48
@danielpacak danielpacak marked this pull request as draft June 30, 2020 15:55
@danielpacak danielpacak force-pushed the integration_tests_scaffold branch 5 times, most recently from dc33fab to f9766c6 Compare July 24, 2020 21:42
@danielpacak danielpacak marked this pull request as ready for review July 24, 2020 21:44
@danielpacak danielpacak requested review from danielsagi and simar7 July 24, 2020 22:10

Describe("Running init command", func() {
It("should initialize Starboard", func() {
cmd := exec.Command(starboardCmd, []string{"init", "-v", "3"}...)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak force-pushed the integration_tests_scaffold branch from f9766c6 to fc6f200 Compare July 24, 2020 22:31
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak removed the request for review from simar7 July 27, 2020 09:49
@danielpacak danielpacak merged commit bce75c3 into master Jul 27, 2020
@danielpacak danielpacak deleted the integration_tests_scaffold branch July 27, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant