Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Summary Columns for ConfigAudits and KubeHunter Reports #158

Merged
merged 3 commits into from
Sep 23, 2020

Conversation

danielsagi
Copy link
Contributor

@danielsagi danielsagi commented Sep 21, 2020

This PR adds additional printer columns to show summary for ConfigAudits and KubeHunter reports. (like already implemented for vulnerabilities reports)

Examples

Config Audits

$ k get configaudit -o wide                                        
NAME                          SCANNER   AGE     DANGER   WARNING
deployment.nginx-deployment   Polaris   6m31s   0        16

kube-hunter

$ k get kubehunter -o wide    
NAME      SCANNER       AGE   HIGH   MEDIUM   LOW
cluster   kube-hunter   3s    1      1        1

As described in the following issues

Closes #149
Closes #148

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #158 into master will decrease coverage by 0.32%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage   33.31%   32.99%   -0.33%     
==========================================
  Files          33       33              
  Lines        1639     1655      +16     
==========================================
  Hits          546      546              
- Misses        997     1013      +16     
  Partials       96       96              
Impacted Files Coverage Δ
pkg/polaris/converter.go 2.04% <0.00%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd8e497...9cf7a09. Read the comment docs.

Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@danielpacak danielpacak merged commit ca60574 into master Sep 23, 2020
@danielpacak danielpacak deleted the add_summary_ca_kube_hunter branch September 23, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants