-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Init command #151
Conversation
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
- Coverage 39.08% 35.67% -3.42%
==========================================
Files 33 33
Lines 1842 1766 -76
==========================================
- Hits 720 630 -90
- Misses 1034 1048 +14
Partials 88 88
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but I think you can delete some of the literals in the code in favour of the new ConfigMap?
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
The goal here is to review and tidy up what we're doing in the
init
command and set the stage for implementing scanners config feature:starboard
starboard
SA (+ mount API token only if necessary)starboard
and make it generic. Introduce naming convention for keys, i.e.trivy.
orpolaris.
to group configuration parameters by scanner. We'll introduce more config params in the future.init
command. This is to integrate with other tools / frameworks which do not want to or cannot executestarboard init
command:Signed-off-by: Daniel Pacak pacak.daniel@gmail.com