fix: remove compliance specKind field #1016
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1016 +/- ##
==========================================
+ Coverage 58.00% 58.18% +0.17%
==========================================
Files 70 70
Lines 9097 9100 +3
==========================================
+ Hits 5277 5295 +18
+ Misses 3293 3281 -12
+ Partials 527 524 -3
Continue to review full report at Codecov.
|
chen-keinan
force-pushed
the
fix/remove-compliance-report-spec-kind
branch
from
e042ec3 to
644c6e4
Compare
| @@ -105,7 +105,10 @@ func (w *cm) createComplianceDetailReport(ctx context.Context, spec v1alpha1.Rep | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: name, | |||
| }, | |||
| Report: v1alpha1.ClusterComplianceDetailReportData{UpdateTimestamp: metav1.NewTime(ext.NewSystemClock().Now()), Summary: summary, Type: v1alpha1.Compliance{Kind: strings.ToLower(spec.Kind), Name: name, Description: strings.ToLower(spec.Description), Version: spec.Version}, ControlChecks: controlChecksDetails}, | |||
| Report: v1alpha1.ClusterComplianceDetailReportData{UpdateTimestamp: metav1.NewTime(ext.NewSystemClock().Now()), | |||
There was a problem hiding this comment.
It's not directly related to this PR, but I spot it right now.
Using ext.NewSystemClock().Now() instead of injecting ext.Clock interface doesn't make much sense. You could just use time.Now() and keep this code untestable.
The ext.Clock interface was introduce to easily swap implementation of the clock in unit tests from ext.NewSystemClock() to ext.NewFixedClock(fixedTime time.Time) with dependency injection pattern.
remove specKind field from compliance reports