chore: add log context when nsa update fails (#1104)

Signed-off-by: chenk <hen.keinan@gmail.com>
aquasecurity · Apr 4, 2022 · 1c26090 · 1c26090
1 parent 45acabb
commit 1c26090
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/pkg/compliance/clustercompliancereport.go b/pkg/compliance/clustercompliancereport.go
@@ -60,7 +60,11 @@ func (r *ClusterComplianceReportReconciler) generateComplianceReport(ctx context
 			return fmt.Errorf("failed to check report cron expression %w", err)
 		}
 		if utils.DurationExceeded(durationToNextGeneration) {
-			return r.Mgr.GenerateComplianceReport(ctx, report.Spec)
+			err = r.Mgr.GenerateComplianceReport(ctx, report.Spec)
+			if err != nil {
+				log.Error(err, "failed to generate compliance report")
+			}
+			return err
 		}
 		log.V(1).Info("RequeueAfter", "durationToNextGeneration", durationToNextGeneration)
 		ctrlResult.RequeueAfter = durationToNextGeneration

diff --git a/pkg/compliance/io.go b/pkg/compliance/io.go
@@ -64,7 +64,7 @@ func (w *cm) GenerateComplianceReport(ctx context.Context, spec v1alpha1.ReportS
 	//create cluster compliance details report
 	err = w.createComplianceDetailReport(ctx, spec, smd, checkIdsToResults, st)
 	if err != nil {
-		return err
+		return fmt.Errorf("failed to create compliance detail report name: %s with error %w", strings.ToLower(fmt.Sprintf("%s-%s", spec.Name, "details")), err)
 	}
 	//generate cluster compliance report
 	updatedReport, err := w.createComplianceReport(ctx, spec, st, controlChecks)