Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Pass Action as arg to the Check() method #64

Merged
merged 2 commits into from
Feb 17, 2020
Merged

refactor: Pass Action as arg to the Check() method #64

merged 2 commits into from
Feb 17, 2020

Conversation

danielpacak
Copy link
Contributor

No description provided.

@danielpacak danielpacak requested a review from knqyf263 February 17, 2020 15:51
@codecov-io
Copy link

codecov-io commented Feb 17, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e46c1b2). Click here to learn what that means.
The diff coverage is 61.7%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #64   +/-   ##
=========================================
  Coverage          ?   70.54%           
=========================================
  Files             ?        5           
  Lines             ?      387           
  Branches          ?        0           
=========================================
  Hits              ?      273           
  Misses            ?       99           
  Partials          ?       15
Impacted Files Coverage Δ
pkg/cmd/policy_rule_matcher.go 93.1% <100%> (ø)
pkg/cmd/list.go 56.38% <59.09%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46c1b2...85e01f4. Read the comment docs.

@danielpacak
refactor: Pass Action as arg to the Check() method
af925b1 
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
@danielpacak danielpacak changed the title refactor: Pass Action as arg to the check method refactor: Pass Action as arg to the Check() method Feb 17, 2020
knqyf263
knqyf263 approved these changes Feb 17, 2020
View reviewed changes
pkg/cmd/list.go Outdated
if err != nil {
err = fmt.Errorf("validationg args: %v", err)
err = fmt.Errorf("validationg: %v", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Suggested change
err = fmt.Errorf("validationg: %v", err)
err = fmt.Errorf("validation: %v", err)

@danielpacak @knqyf263
fix: typo
85e01f4 
Co-Authored-By: Teppei Fukuda <knqyf263@gmail.com>
@danielpacak danielpacak merged commit 922e198 into aquasecurity:master Feb 17, 2020
@danielpacak danielpacak deleted the checker_api branch February 17, 2020 19:40
@danielpacak danielpacak mentioned this pull request Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielpacak @codecov-io @knqyf263