Skip to content

Fixes Issue #494 - add tests for CIS 1.5 #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Dec 5, 2019
Merged

Fixes Issue #494 - add tests for CIS 1.5 #530

merged 24 commits into from
Dec 5, 2019

Conversation

robertojrojas
Copy link
Contributor

Fixes Issue #494
Thanks @ttousai for getting most of the work done on this. 👍

@codecov
Copy link

codecov bot commented Dec 3, 2019 •
edited
Loading

Codecov Report

Merging #530 into master will decrease coverage by 0.94%.
The diff coverage is 48.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
- Coverage   64.49%   63.55%   -0.95%     
==========================================
  Files          12       12              
  Lines        1059     1103      +44     
==========================================
+ Hits          683      701      +18     
- Misses        337      363      +26     
  Partials       39       39
Impacted Files Coverage Δ
check/check.go 71.09% <ø> (ø) ⬆️
cmd/root.go 51.31% <0%> (-7.78%) ⬇️
cmd/util.go 72.68% <55.55%> (-0.69%) ⬇️
cmd/run.go 42.55% <56.25%> (-0.31%) ⬇️
cmd/common.go 35% <65.51%> (+2.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7015f4b...9fffc14. Read the comment docs.

@robertojrojas robertojrojas changed the title [WIP] Fixes Issue #494 Fixes Issue #494 Dec 3, 2019
@robertojrojas robertojrojas requested a review from lizrice December 3, 2019 17:06
lizrice
lizrice suggested changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks OK though I do have a few comments.

This doesn’t have the auto-detection part, right?

@lizrice lizrice changed the title Fixes Issue #494 Fixes Issue #494 - add tests for CIS 1.5 Dec 4, 2019
@robertojrojas
Copy link
Contributor Author

Mostly looks OK though I do have a few comments.

This doesn’t have the auto-detection part, right?
I added auto-detection with conditions so it runs the correct targets based on the CIS benchmark version.

@robertojrojas robertojrojas requested a review from lizrice December 4, 2019 22:25
lizrice
lizrice approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried it out but just from a code read it looks fine (apart from a couple of tiny tiny docs things)

@robertojrojas @lizrice
Update README.md
14f5f6c 
Co-Authored-By: Liz Rice <liz@lizrice.com>
robertojrojas and others added 2 commits December 5, 2019 15:07
@robertojrojas @lizrice
Update README.md
c097d28 
Co-Authored-By: Liz Rice <liz@lizrice.com>
@robertojrojas
fixes as per PR review
9fffc14
@robertojrojas robertojrojas merged commit af976e6 into aquasecurity:master Dec 5, 2019
@robertojrojas robertojrojas mentioned this pull request Dec 5, 2019
Closed
caruccio pushed a commit to getupcloud/kube-bench that referenced this pull request Feb 19, 2021
@robertojrojas @caruccio
Fixes Issue aquasecurity#494 - add tests for CIS 1.5 (aquasecurity#530)
c1428a0 
* Initial commit.

* Add master and node config.

* Add section 5 of CIS 1.5.1.

* Split sections into section files

* Fix YAML issues.

* adds target translation

* adds target translation

* adds cis-1.5 mapping

* fixed tests

* fixes are per PR

* fixed intergration test

* integration kind test file to appropriate ks8 version

* fixed etcd text

* fixed README

* fixed text

* etcd: fixed grep path

* etcd: fixes

* fixed error message bug

* Update README.md

Co-Authored-By: Liz Rice <liz@lizrice.com>

* Update README.md

Co-Authored-By: Liz Rice <liz@lizrice.com>

* fixes as per PR review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lizrice lizrice lizrice approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertojrojas @lizrice @ttousai