-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): Add support for cargo-auditable binaries #119
Conversation
Detect binary information embedded via https://github.com/rust-secure-code/cargo-auditable Signed-off-by: Tom Fay <tomfay@microsoft.com>
Signed-off-by: Tom Fay <tomfay@microsoft.com>
1d7a13c
to
9cb41d3
Compare
Signed-off-by: Tom Fay <tomfay@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I left a small comment.
} | ||
for _, tt := range tests { | ||
t.Run(tt.name, func(t *testing.T) { | ||
f, err := os.Open(tt.inputFile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like defer f.Close() is missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added here, and to the golang binary tests which I based these off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Tom Fay <tomfay@microsoft.com>
Thanks for your great contribution! |
Per aquasecurity/trivy#2664, https://github.com/rust-secure-code/cargo-auditable is a cargo subcommand to embed Rust crate dependency information into binaries for subsequent vulnerability checking.
This PR updates go-dep-parser so that it can read this dependency information, using https://github.com/microsoft/go-rustaudit - a module that extracts and parses the dependency information.
Signed-off-by: Tom Fay tomfay@microsoft.com