This repository was archived by the owner on Jun 21, 2022. It is now read-only.
fix(docker): getting an image by ID or a name with tag #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
suggested changes
Mar 17, 2022
image/daemon/docker.go
Outdated
| imageID = ref.String() // Image ID uses "<Image_ID>" pattern | ||
| inspect, _, err = c.ImageInspectWithRaw(context.Background(), imageID) | ||
| if err != nil { | ||
| return nil, cleanup, xerrors.Errorf("unable to inspect the image (%s): %w", ref.Name(), err) |
There was a problem hiding this comment.
ref.String() returns an original value. I think ref.String() is better here.
Suggested change
| return nil, cleanup, xerrors.Errorf("unable to inspect the image (%s): %w", ref.Name(), err) | |
| return nil, cleanup, xerrors.Errorf("unable to inspect the image (%s): %w", imageID, err) |
image/daemon/docker.go
Outdated
| @@ -24,10 +24,14 @@ func DockerImage(ref name.Reference) (Image, func(), error) { | |||
| } | |||
| }() | |||
|
|
|||
| imageID := ref.String() | |||
| imageID := ref.Name() // Image ID uses "<Image_name>:<Tag>" pattern | |||
There was a problem hiding this comment.
Suggested change
| imageID := ref.Name() // Image ID uses "<Image_name>:<Tag>" pattern | |
| // <image_name>:<tag> pattern like "alpine:3.15" | |
| // or | |
| // <image_name>@<digest> pattern like "alpine@sha256:21a3deaa0d32a8057914f36584b5288d2e5ecc984380bc0118285c70fa8c9300" | |
| imageID := ref.Name() |
There was a problem hiding this comment.
You missed my suggested change.
image/daemon/docker.go
Outdated
| inspect, _, err := c.ImageInspectWithRaw(context.Background(), imageID) | ||
| if err != nil { | ||
| return nil, cleanup, xerrors.Errorf("unable to inspect the image (%s): %w", imageID, err) | ||
| imageID = ref.String() // Image ID uses "<Image_ID>" pattern |
There was a problem hiding this comment.
nit
Suggested change
| imageID = ref.String() // Image ID uses "<Image_ID>" pattern | |
| imageID = ref.String() // <image_id> pattern like `5ac716b05a9c` |
knqyf263
approved these changes
Mar 17, 2022
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fanaltries to find an image by name (with tag).If it's not found,
fanalwill look for an image by ID.Fixes a problem from #405