ensure pluginDone is called under all circumstances #563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #552, Fixes #557
The implementation of async.mapValuesLimit in
engine.collector
fails to resolve all of the asynchronous functions. This prevents the callback function from executing, which meansoutputHandler.close()
never gets called. That means output is never written to the console, nor saved to JSON.If we move the call to
pluginDone
out of theif
statement, it is called under all circumstances, ensuring we get proper output.