Skip to content

fix: allow to use wildcards in pluginId again #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pbilyak wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: allow to use wildcards in pluginId again #2132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion postprocess/suppress.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ module.exports = {
throw new Error(`Invalid suppression format: ${expr}. Expected format: pluginId:region:resourceId`);
}

const pluginPattern = /^[A-Za-z0-9]{1,255}$/; // eslint-disable-line
const pluginPattern = /^[A-Za-z0-9*]{1,255}$/; // eslint-disable-line
const regionPattern = /^[A-Za-z0-9\-_]{1,255}$/; // eslint-disable-line
const resourcePattern = /^[ A-Za-z0-9._~()'!*:@,;+?#$%^&={}\\[\]\\|\"/-]{1,255}$/; // eslint-disable-line
const [pluginId, region, resourceId] = parts;
Expand Down
4 changes: 2 additions & 2 deletions postprocess/suppress.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ describe('create', function () {
});

it('should return the filter if matches', function () {
var filter = suppress.create(['plugin123:us-east-1:n*']);
expect(filter('plugin123:us-east-1:name')).to.equal('plugin123:us-east-1:n*');
var filter = suppress.create(['p*:us-east-1:n*']);
expect(filter('plugin123:us-east-1:name')).to.equal('p*:us-east-1:n*');
});

it('should return the filter if matches whole word', function () {
Expand Down