added validation for suppress regex #2125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzurielweisberg
approved these changes
Feb 3, 2025
alphadev4
approved these changes
Feb 4, 2025
Contributor
Author
|
Added input validation for suppression expressions to prevent potential ReDoS vulnerabilities. The validation ensures suppression patterns are properly formatted and restricts malicious regex patterns while maintaining existing functionality |
alphadev4
approved these changes
Feb 6, 2025
|
Hi @AkhtarAmir and @tzurielweisberg. This change removed the ability to use wildcards in suppression rules, which is a significant loss of functionality. Removed here: bfe40f9. Was this intentional? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.