Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

rgw/sfs: upgrade existing db for bucket mtime #252

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

jecluis
Copy link
Member

@jecluis jecluis commented Nov 21, 2023

Fixes: aquarist-labs/s3gw#811

Signed-off-by: Joao Eduardo Luis <joao@suse.com>

@jecluis jecluis added kind/bug Something isn't working area/rgw-sfs RGW & SFS related labels Nov 21, 2023
@jecluis jecluis added this to the v0.24.0 milestone Nov 21, 2023
@jecluis jecluis requested review from tserong and irq0 November 21, 2023 03:27
@jecluis jecluis self-assigned this Nov 21, 2023
tserong
tserong previously approved these changes Nov 21, 2023
Copy link
Member

@tserong tserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I've repeated both tests described in https://github.com/aquarist-labs/s3gw/issues/811 with this applied, and the database migrates fine.

irq0
irq0 previously requested changes Nov 21, 2023
src/rgw/driver/sfs/sqlite/dbconn.h Outdated Show resolved Hide resolved
@jecluis jecluis requested a review from irq0 November 21, 2023 09:54
@jecluis
Copy link
Member Author

jecluis commented Nov 21, 2023

I pushed a new patch, but for some reason it's not showing up on the PR. wth

Fixes: aquarist-labs/s3gw#811

Signed-off-by: Joao Eduardo Luis <joao@suse.com>
@jecluis jecluis merged commit d4b05d4 into aquarist-labs:s3gw Nov 21, 2023
5 checks passed
@jecluis jecluis deleted the wip-fix-mtime-db branch November 21, 2023 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/rgw-sfs RGW & SFS related kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] upgrading from v0.22 to v0.23-rc1 fails - buckets table no longer compatible
3 participants