Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

CI Action: Build Image on PR label #203

Merged
merged 1 commit into from
Sep 7, 2023
Merged

CI Action: Build Image on PR label #203

merged 1 commit into from
Sep 7, 2023

Conversation

irq0
Copy link
Member

@irq0 irq0 commented Sep 6, 2023

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)

@irq0 irq0 self-assigned this Sep 6, 2023
@irq0 irq0 added the ci/build-s3gw-image Build and push a container image label Sep 6, 2023
ci: Add image build and push action
2f44009 
Triggerd by "ci/build-s3gw-image" tag or manually

Signed-off-by: Marcel Lauhoff <marcel.lauhoff@suse.com>
@irq0 irq0 added area/CI Continuous Integration ci/build-s3gw-image Build and push a container image and removed ci/build-s3gw-image Build and push a container image labels Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

📦 quay.io/s3gw/s3gw:pr-c1744add67a177904952035b083fc5d14c4ffe25-6094249128-1 https://quay.io/repository/s3gw/s3gw?tab=tags&tag=pr-c1744add67a177904952035b083fc5d14c4ffe25-6094249128-1

@irq0 irq0 requested a review from m-ildefons September 6, 2023 08:29
@irq0 irq0 added this to the v0.21.0 milestone Sep 6, 2023
@irq0
Copy link
Member Author

irq0 commented Sep 6, 2023

Killed "Test s3gw", as it doesn't test anything related to this change

m-ildefons
m-ildefons approved these changes Sep 7, 2023
View reviewed changes
Copy link

@m-ildefons m-ildefons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPGTM, approved. Found some nits, no blockers though.

.github/workflows/build-image-on-pr-label.yaml
IMAGE_TAG: pr-${{ github.workflow_sha }}-${{ github.run_id }}-${{ github.run_attempt }}

jobs:
tests:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: rename to "build"

.github/workflows/build-image-on-pr-label.yaml
with:
path: s3gw/ceph
submodules: recursive

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: double empty line

.github/workflows/build-image-on-pr-label.yaml
Comment on lines +35 to +38
- name: Setup Python
uses: actions/setup-python@v4
with:
python-version: 3.8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed anywhere?

.github/workflows/build-image-on-pr-label.yaml

jobs:
tests:
if: github.event.label.name == 'ci/build-s3gw-image' || github.event_name == 'workflow_dispatch'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'd choose a shorter label for convenience: ci/build

@irq0 irq0 merged commit bdc4a18 into s3gw Sep 7, 2023
7 of 8 checks passed
@tserong tserong mentioned this pull request Sep 11, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m-ildefons m-ildefons m-ildefons approved these changes

Assignees

@irq0 irq0

Labels
area/CI Continuous Integration ci/build-s3gw-image Build and push a container image
Projects
S3GW
Status: Done
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@irq0 @m-ildefons