feat(slsa-framework/slsa-verifier): SLSA provenance #32209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
commented
Feb 15, 2025
| @@ -6,6 +6,9 @@ packages: | |||
| description: Verify provenance from SLSA compliant builders | |||
| asset: slsa-verifier-{{.OS}}-{{.Arch}} | |||
| format: raw | |||
| slsa_provenance: | |||
| type: github_release | |||
| asset: slsa-verifier-{{.OS}}-{{.Arch}}.intoto.jsonl | |||
There was a problem hiding this comment.
I'm not sure if asset here works this way.
I guess not related to this, but the test fails for me (on linux/amd64) with:
ERRO[0043] install the package aqua_version=2.44.1 env=linux/amd64 error="open the file (/root/.local/share/aquaproj-aqua/pkgs/github_release/github.com/slsa-framework/slsa-verifier/v2.7.0/slsa-verifier-linux-amd64/slsa-verifier-linux-amd64): open /root/.local/share/aquaproj-aqua/pkgs/github_release/github.com/slsa-framework/slsa-verifier/v2.7.0/slsa-verifier-linux-amd64/slsa-verifier-linux-amd64: text file busy" package_name=slsa-framework/slsa-verifier package_version=v2.7.0 program=aqua registry=standard
This failure does seem to be caused by these changes somehow. But I have not looked into it.
There are some other test failures for me that happen for slsa-framework/slsa-verifier even without these changes.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/slsa-framework/slsa-verifier/releases
Check List
Require signed commits, so all commits must be signedcmdx sto scaffold code