Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hashicorp/vagrant/vagrant-go #32070

Merged
merged 7 commits into from
Feb 15, 2025

Conversation

kdihalas
Copy link
Contributor

@kdihalas kdihalas commented Feb 13, 2025

hashicorp/vagrant/vagrant-go - Vagrant is a tool for building and distributing development environments

Check List

solves: #32069

@kdihalas kdihalas changed the title Feat/hashicorp/vagrant feat: add hashicorp/vagrant Feb 13, 2025
@kdihalas kdihalas force-pushed the feat/hashicorp/vagrant branch from f79e3c7 to 293a859 Compare February 13, 2025 01:12
@suzuki-shunsuke
Copy link
Member

Thank you for your contribution!

@suzuki-shunsuke
Copy link
Member

Vagrant is built with Ruby, so I thought it's difficult for aqua to support it.
But I didn't know Vagrant releases executable binaries.

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Feb 13, 2025
Comment on lines 16 to 18
supported_envs:
- linux/amd64
- darwin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝

Vagrant supports Windows, but aqua doesn't suport .msi.
Pre-built binaries for Windows aren't released at GitHub Releases.

https://developer.hashicorp.com/vagrant/install?product_intent=vagrant#windows

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Feb 13, 2025

Oh, seems like Vgrant v2.4.3 was built with Go, not Ruby.
And it doesn't work on my laptop (M1 Pro).

$ aqua which -v vagrant
v2.4.3
$ vagrant --help
This is an experimental version of Vagrant. Please note that some things may
not work as you expect and this version of Vagrant is not compatible with the 
stable version of Vagrant. For more information about vagrant-go read the docs 
at https://www.vagrantup.com/docs/experimental/vagrant_go. To disable this 
warning set the environment variable 'VAGRANT_SUPPRESS_GO_EXPERIMENTAL_WARNING'.
panic: Unrecognized remote plugin message: WARNING: This is an experimental version of Vagrant. Please note that some things may
This usually means
  the plugin was not compiled for this architecture,
  the plugin is missing dynamic-link libraries necessary to run,
  the plugin is not executable by this process due to file permissions, or
  the plugin failed to negotiate the initial go-plugin protocol handshake

Additional notes about plugin:
  Path: /Users/***/.local/share/aquaproj-aqua/bin/vagrant
  Mode: -rwxr-xr-x
  Owner: 502 [***] (current: 502 [***])
  Group: 20 [***] (current: 20 [***])
  MachO architecture: CpuArm64 (current architecture: arm64)


goroutine 1 [running]:
github.com/hashicorp/vagrant/internal/cli.Main({0x1400003a040?, 0x10300a138?, 0x1045e1680?})
	/home/runner/work/vagrant-builders/vagrant-builders/vagrant-source/internal/cli/main.go:92 +0x670
main.main()
	/home/runner/work/vagrant-builders/vagrant-builders/vagrant-source/cmd/vagrant/main.go:17 +0xa8

https://developer.hashicorp.com/vagrant/docs/experimental/vagrant_go

@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Feb 13, 2025

I think we should rename the package to hashicorp/vagrant/vagrant-go or something in order to clarify this package is not Vagrant Ruby but Vagrant Go.

  • hashicorp/vagrant/vagrant-go
  • hashicorp/vagrant/go

@suzuki-shunsuke
Copy link
Member

Does Vagrant Go work on your machine?
I hesitate to add this tool because it didn't work on my machine.

@kdihalas
Copy link
Contributor Author

Hi @suzuki-shunsuke i use Linux and yes it works, don't have a Mac with ARM to test it.

@kdihalas
Copy link
Contributor Author

they do release arm64 in the 2.4.4.dev+000386-a1ceec1d version but i wanted to avoid adding a pre-release binary

@suzuki-shunsuke
Copy link
Member

Hi suzuki-shunsuke i use Linux and yes it works, don't have a Mac with ARM to test it.

I see. Thank you.

I renamed the package to hashicorp/vagrant/vagrant-go.

@suzuki-shunsuke suzuki-shunsuke changed the title feat: add hashicorp/vagrant feat: add hashicorp/vagrant/vagrant-go Feb 15, 2025
@suzuki-shunsuke suzuki-shunsuke merged commit 1bfad55 into aquaproj:main Feb 15, 2025
17 checks passed
@suzuki-shunsuke suzuki-shunsuke added this to the v4.314.0 milestone Feb 15, 2025
@suzuki-shunsuke
Copy link
Member

@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Feb 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants