fix: support running action in a container #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` Error: /home/runner/work/aqua-installer/aqua-installer/./action.yaml: Error: /home/runner/work/aqua-installer/aqua-installer/./action.yaml: (Line: 91, Col: 1, Idx: 3203) - (Line: 91, Col: 1, Idx: 3203): While scanning a simple key, could not find expected ':'. Error: System.ArgumentException: Unexpected type '' encountered while reading 'action manifest root'. The type 'MappingToken' was expected. at GitHub.DistributedTask.ObjectTemplating.Tokens.TemplateTokenExtensions.AssertMapping(TemplateToken value, String objectDescription) at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile) Error: Fail to load /home/runner/work/aqua-installer/aqua-installer/./action.yaml ```
suzuki-shunsuke
added a commit
to suzuki-shunsuke/test-github-action
that referenced
this pull request
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #461
In a container the variable
${{ github.action_path }}is wrong, so action can't access the scriptaqua-installer.This is a known issue of GitHub Actions.
To solve the issue, we copy the content of the script
aqua-installerinto action itself, then action don't have to access the scriptaqua-installer.