Skip to content

Add empty email check #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LICENSE
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright 2022 Aquality Automation
Copyright 2023 Aquality Automation

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ Feature: Demo
When I fill contact form using following data:
| Name | Peter Parker |
| Company | Aquality Automation |
| Email | aquality-auto@a1qa.com |
| Phone | +44 208 816 7320 |
| Comment | I'd like to contact you! |
And I accept Privacy and Cookies Policy
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ public void fillContactUsPage(@Transpose ContactUsInfo contactUsInfo) {
contactUsPage.setName(contactUsInfo.getName())
.setCompany(contactUsInfo.getCompany())
.setPhone(contactUsInfo.getPhone())
.setEmail(contactUsInfo.getEmail())
.setComment(contactUsInfo.getComment());
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public class ContactUsPage extends BaseAppForm {
private final ITextBox txbComment = getElementFactory().getTextBox(By.id("your-message"), "Comment");
private final ICheckBox cmbPrivacy = getElementFactory().getCheckBox(By.name("privacy"), "Privacy", ElementState.EXISTS_IN_ANY_STATE);
private final IButton btnSend = getElementFactory().getButton(By.xpath("//*[contains(@class,'contactsForm__submit')]//button"), "Send");
private final ILabel lblEmailAlert = getElementFactory().getLabel(By.id("modal-contacts-thanks"), "Email validating message");
private final ILabel lblEmailAlert = getElementFactory().getLabel(By.xpath("//div[contains(@class,'error')]//input[@id='your-email']"), "Email validating message");

public ContactUsPage(){
super(By.xpath("//section[contains(@class,'contactsForm')]"), "Contact Us");
Expand Down
43 changes: 39 additions & 4 deletions aquality-selenium-template/src/main/resources/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,17 @@
"chrome": {
"webDriverVersion": "latest",
"capabilities": {
"enableVNC": true
},
"options": {
"intl.accept_languages": "en",
"safebrowsing.enabled": "true",
"profile.default_content_settings.popups": "0",
"disable-popup-blocking": "true",
"download.prompt_for_download": "false",
"download.default_directory": "//home//selenium//downloads"
"download.default_directory": "./downloads"
},
"loggingPreferences": {
"Performance": "All"
},
"startArguments": [
"window-size=1920,1080",
Expand All @@ -28,14 +30,31 @@
"--headless"
]
},
"edge": {
"webDriverVersion": "latest",
"capabilities": {
},
"options": {
"intl.accept_languages": "en",
"safebrowsing.enabled": "true",
"profile.default_content_settings.popups": "0",
"disable-popup-blocking": "true",
"download.prompt_for_download": "false",
"download.default_directory": "./downloads"
},
"loggingPreferences": {
"Performance": "All"
},
"startArguments": []
},
"firefox": {
"webDriverVersion": "latest",
"capabilities": {
"enableVNC": true
},
"options": {
"intl.accept_languages": "en",
"browser.download.dir": "//home//selenium//downloads",
"browser.download.dir": "./downloads",
"browser.download.folderList": 2,
"browser.helperApps.neverAsk.saveToDisk": "application/octet-stream, application/x-debian-package, application/x-www-form-urlencod, application/json, application/x-compressed, application/x-zip-compressed, application/zip, multipart/x-zip, text/plain, text/csv",
"browser.helperApps.alwaysAsk.force": false,
Expand All @@ -57,6 +76,21 @@
"ignoreProtectedModeSettings": true
}
},
"opera": {
"webDriverVersion": "latest",
"binaryLocation": "%USERPROFILE%\\AppData\\Local\\Programs\\Opera\\launcher.exe",
"capabilities": {
},
"options": {
"intl.accept_languages": "en",
"safebrowsing.enabled": "true",
"profile.default_content_settings.popups": "0",
"disable-popup-blocking": "true",
"download.prompt_for_download": "false",
"download.default_directory": "./downloads"
},
"startArguments": ["--remote-debugging-port=9222", "--no-sandbox", "--disable-dev-shm-usage"]
},
"safari": {
"downloadDir": "/Users/username/Downloads"
}
Expand All @@ -74,7 +108,8 @@
"pollingInterval": 300
},
"logger": {
"language": "en"
"language": "en",
"logPageSource": true
},
"elementCache": {
"isEnabled": false
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,15 @@

<properties>
<aspectj.version>1.8.10</aspectj.version>
<restassured.version>5.2.0</restassured.version>
<restassured.version>5.3.0</restassured.version>
<data.provider.thread.count>4</data.provider.thread.count>
</properties>

<dependencies>
<dependency>
<groupId>com.github.aquality-automation</groupId>
<artifactId>aquality-selenium</artifactId>
<version>3.1.0</version>
<version>3.2.0</version>
</dependency>

<dependency>
Expand Down