-
Notifications
You must be signed in to change notification settings - Fork 11
Add possibility to set number of threads for parallel run #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to set number of threads for parallel run #19
Conversation
To give user control of number of threads to use. Default to 4.
pom.xml
Outdated
<properties> | ||
<property> | ||
<name>dataproviderthreadcount</name> | ||
<value>${thread.count}</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in TestNG there is an option called threadcount
, so the name thread.count
for other option is confusing.
http://testng.org/doc/documentation-main.html#running-testng
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any suggestions on naming? dataproviderthreadcount
? threads
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure that we should use dataproviderthreadcount not threadcount?
if so, we can say data.provider.thread.count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty sure it is dataproviderthreadcount
https://cucumber.io/docs/guides/parallel-execution/#testng
The default thread count of the dataprovider in parallel mode is 10. To change this the
dataproviderthreadcount
property needs to be added to the configuration section of the Surefire or Failsafe plugin in the POM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
year, but as I see we parallelized by classes, not by methods. I'm not sure, is this correct when we use dataproviderthreadcount
option, does it take any effect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to limit threads in current version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
threadcount? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope
<properties>
<property>
<name>threadcount</name>
<value>${thread.count}</value>
</property>
</properties>
does not work in our case
@mialeska, renamed parameter to |
Kudos, SonarCloud Quality Gate passed!
|
To give user control of number of threads to use.
Default to 4.