Skip to content

Update to Selenium 4.13.0 and remove webDriverManager dependency +semver: feature #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Update to Selenium 4.13.0 and remove webDriverManager dependency +semver: feature #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-maven-central.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:

- name: Step 6 - Publish package
run: |
mvn -Dmaven.test.skip=true -Drevision=${{ steps.gitversion.outputs.semVer }} deploy
mvn -Dmaven.test.skip=true -P release -Drevision=${{ steps.gitversion.outputs.semVer }} deploy
env:
MVN_CENTRAL_USERNAME: ${{ secrets.OSSRH_USERNAME }}
MVN_CENTRAL_PASSWORD: ${{ secrets.OSSRH_TOKEN }}
Expand Down
13 changes: 3 additions & 10 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,18 +120,12 @@
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
<artifactId>selenium-java</artifactId>
<version>4.8.1</version>
</dependency>
<dependency>
<groupId>io.github.bonigarcia</groupId>
<artifactId>webdrivermanager</artifactId>
<version>5.6.3</version>
<scope>test</scope>
<version>4.13.0</version>
</dependency>
<dependency>
<groupId>io.appium</groupId>
<artifactId>java-client</artifactId>
<version>8.3.0</version>
<version>8.6.0</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down Expand Up @@ -264,8 +258,7 @@
<configuration>
<serverId>ossrh</serverId>
<nexusUrl>https://s01.oss.sonatype.org/</nexusUrl>
<autoReleaseAfterClose>false</autoReleaseAfterClose>
<skipStagingRepositoryClose>true</skipStagingRepositoryClose>
<autoReleaseAfterClose>true</autoReleaseAfterClose>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 0 additions & 2 deletions src/test/java/tests/applications/browser/AqualityServices.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import aquality.selenium.core.applications.AqualityModule;
import com.google.inject.Injector;
import io.github.bonigarcia.wdm.WebDriverManager;

public class AqualityServices extends aquality.selenium.core.applications.AqualityServices<ChromeApplication> {
private static final ThreadLocal<AqualityServices> INSTANCE_CONTAINER = ThreadLocal.withInitial(AqualityServices::new);
Expand All @@ -28,7 +27,6 @@ public static ChromeApplication getApplication() {
}

private static ChromeApplication startChrome(Injector injector) {
WebDriverManager.chromedriver().setup();
if (injector == null) {
throw new RuntimeException("cannot start Chrome without DI injector");
}
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/tests/applications/browser/ChromeApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class ChromeApplication implements IApplication {
private final RemoteWebDriver driver;

ChromeApplication(long implicitWaitSeconds) {
driver = new ChromeDriver(new ChromeOptions().addArguments("--headless", "--remote-allow-origins=*"));
driver = new ChromeDriver(new ChromeOptions().addArguments("--headless"));
setImplicitWaitTimeout(Duration.ofSeconds(implicitWaitSeconds));
}

Expand Down