Signed transactions for token minting module #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnChangUK
requested review from
BriungRi,
jillxuu and
bowenyang007
as code owners
JohnChangUK
force-pushed
the
signed-tx
branch
3 times, most recently
from
1bc8cf8
to
866ca4e
Compare
jillxuu
requested changes
Apr 24, 2024
There was a problem hiding this comment.
can we modify this module in a way that its not just serving mint but also other ops? so prob
- rename to get rid of
mint - instead of creating a resource for proof challenge here, we should just pass in the challenge as bytes and verify that?
it will make this module a lot more flexible for different use cases
Good idea, have updated to do so! |
jillxuu
reviewed
Apr 25, 2024
| @@ -0,0 +1,97 @@ | |||
| module minter::signed_transaction { | |||
There was a problem hiding this comment.
nit: add a comment section above this comment to explain what this module is doing about proof challenge and proof data validation? and then prob share couple potential use cases on how signed txn can be utilized.
jillxuu
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This module allows creating signed transactions which verify a creator has signed a message with the specified public key.