Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update builder.Dockerfile for Move2 #15289

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Update builder.Dockerfile for Move2 #15289

merged 1 commit into from
Nov 15, 2024

Conversation

sherry-x
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@sherry-x sherry-x requested a review from a team as a code owner November 15, 2024 18:10
Copy link

trunk-io bot commented Nov 15, 2024

⏱️ 45m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-tests 12m 🟩
test-target-determinator 5m 🟩
rust-move-tests 5m
rust-doc-tests 5m 🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
rust-cargo-deny 3m 🟩🟩
check-dynamic-deps 3m 🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
general-lints 55s 🟩🟩
semgrep/ci 51s 🟩🟩
file_change_determinator 25s 🟩🟩
file_change_determinator 13s 🟩
execution-performance / single-node-performance 10s 🟩
permission-check 8s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 16m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@sherry-x sherry-x enabled auto-merge (rebase) November 15, 2024 18:15

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on fc146de0e1ff84e24466ae4159e2e6830e485a8e

two traffics test: inner traffic : committed: 14371.07 txn/s, latency: 2765.72 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5464260
two traffics test : committed: 99.95 txn/s, latency: 1579.16 ms, (p50: 1400 ms, p70: 1500, p90: 1600 ms, p99: 9700 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.998, avg: 1.566", "ConsensusProposalToOrdered: max: 0.314, avg: 0.294", "ConsensusOrderedToCommit: max: 0.376, avg: 0.370", "ConsensusProposalToCommit: max: 0.670, avg: 0.664"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.08s no progress at version 6074724 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.81s no progress at version 6074722 (avg 8.63s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 2bb2d43037a93d883729869d65c7c6c75b028fa1 ==> fc146de0e1ff84e24466ae4159e2e6830e485a8e

Compatibility test results for 2bb2d43037a93d883729869d65c7c6c75b028fa1 ==> fc146de0e1ff84e24466ae4159e2e6830e485a8e (PR)
1. Check liveness of validators at old version: 2bb2d43037a93d883729869d65c7c6c75b028fa1
compatibility::simple-validator-upgrade::liveness-check : committed: 8609.58 txn/s, submitted: 8610.17 txn/s, expired: 0.59 txn/s, latency: 2075.48 ms, (p50: 2100 ms, p70: 2200, p90: 2600 ms, p99: 3200 ms), latency samples: 529084
2. Upgrading first Validator to new version: fc146de0e1ff84e24466ae4159e2e6830e485a8e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5755.66 txn/s, latency: 4869.04 ms, (p50: 5400 ms, p70: 5600, p90: 6200 ms, p99: 6300 ms), latency samples: 107160
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6928.98 txn/s, latency: 4670.54 ms, (p50: 4800 ms, p70: 5100, p90: 6200 ms, p99: 6600 ms), latency samples: 233260
3. Upgrading rest of first batch to new version: fc146de0e1ff84e24466ae4159e2e6830e485a8e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6868.84 txn/s, latency: 4158.27 ms, (p50: 4700 ms, p70: 4900, p90: 5000 ms, p99: 5100 ms), latency samples: 128580
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7042.12 txn/s, latency: 4545.08 ms, (p50: 4900 ms, p70: 5000, p90: 5900 ms, p99: 6300 ms), latency samples: 237240
4. upgrading second batch to new version: fc146de0e1ff84e24466ae4159e2e6830e485a8e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11342.36 txn/s, latency: 2432.56 ms, (p50: 2400 ms, p70: 2900, p90: 3300 ms, p99: 3500 ms), latency samples: 200580
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9947.32 txn/s, latency: 3093.09 ms, (p50: 2600 ms, p70: 3400, p90: 4500 ms, p99: 6100 ms), latency samples: 327720
5. check swarm health
Compatibility test for 2bb2d43037a93d883729869d65c7c6c75b028fa1 ==> fc146de0e1ff84e24466ae4159e2e6830e485a8e passed
Test Ok

@sherry-x sherry-x merged commit ade516d into main Nov 15, 2024
93 of 94 checks passed
@sherry-x sherry-x deleted the update-lang-v2 branch November 15, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants