[forge] fixs incl unstable trigger conditions

[rustielin]

Description

Some small fixes to forge unstable

• trigger condition
• use double brackets in inline bash

How Has This Been Tested?

workflow dispatch. also the cron schedule once it's landed

Key Areas to Review

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Move Compiler
• Other (specify)

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[trunk-io]

⏱️ 47m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
dispatch_event	15m	🟩
rust-doc-tests	5m	🟩
execution-performance / test-target-determinator	4m	🟩
test-target-determinator	4m	🟩
rust-cargo-deny	4m	🟩 🟩
check	4m	🟩
rust-move-tests	2m	🟩
rust-move-tests	2m	🟩
determine-test-metadata	2m	🟩
fetch-last-released-docker-image-tag	1m	🟩
check-dynamic-deps	1m	🟩 🟩
general-lints	59s	🟩 🟩
semgrep/ci	46s	🟩 🟩
file_change_determinator	21s	🟩 🟩
file_change_determinator	12s	🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
execution-performance / single-node-performance	10s	16m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[github-actions]

✅ Forge suite realistic_env_max_load success on d544ba8b7c8db5fb4bb91428992909d4690e8f76

two traffics test: inner traffic : committed: 13022.73 txn/s, latency: 3045.73 ms, (p50: 3000 ms, p70: 3000, p90: 3300 ms, p99: 7000 ms), latency samples: 4951580
two traffics test : committed: 99.91 txn/s, latency: 2628.71 ms, (p50: 2600 ms, p70: 2700, p90: 2900 ms, p99: 7900 ms), latency samples: 1800
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.260, avg: 0.225", "QsPosToProposal: max: 0.367, avg: 0.303", "ConsensusProposalToOrdered: max: 0.326, avg: 0.311", "ConsensusOrderedToCommit: max: 0.530, avg: 0.492", "ConsensusProposalToCommit: max: 0.838, avg: 0.803"]
Max non-epoch-change gap was: 1 rounds at version 61061 (avg 0.00) [limit 4], 1.81s no progress at version 61061 (avg 0.22s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.21s no progress at version 2212476 (avg 8.21s) [limit 15].
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite compat success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> d544ba8b7c8db5fb4bb91428992909d4690e8f76

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> d544ba8b7c8db5fb4bb91428992909d4690e8f76 (PR)
1. Check liveness of validators at old version: 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775
compatibility::simple-validator-upgrade::liveness-check : committed: 12804.05 txn/s, latency: 2554.87 ms, (p50: 1900 ms, p70: 2200, p90: 2800 ms, p99: 13000 ms), latency samples: 494920
2. Upgrading first Validator to new version: d544ba8b7c8db5fb4bb91428992909d4690e8f76
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7355.29 txn/s, latency: 3899.62 ms, (p50: 4300 ms, p70: 4500, p90: 4800 ms, p99: 4800 ms), latency samples: 139620
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6425.58 txn/s, latency: 5078.95 ms, (p50: 5200 ms, p70: 5400, p90: 7200 ms, p99: 7400 ms), latency samples: 231280
3. Upgrading rest of first batch to new version: d544ba8b7c8db5fb4bb91428992909d4690e8f76
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6895.41 txn/s, latency: 3946.15 ms, (p50: 4500 ms, p70: 4900, p90: 5100 ms, p99: 5400 ms), latency samples: 124760
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6938.48 txn/s, latency: 4554.32 ms, (p50: 4700 ms, p70: 4900, p90: 6500 ms, p99: 6900 ms), latency samples: 230680
4. upgrading second batch to new version: d544ba8b7c8db5fb4bb91428992909d4690e8f76
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8578.74 txn/s, latency: 2841.55 ms, (p50: 2500 ms, p70: 2700, p90: 6600 ms, p99: 9100 ms), latency samples: 167940
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11745.19 txn/s, latency: 2668.97 ms, (p50: 2600 ms, p70: 2700, p90: 2900 ms, p99: 3600 ms), latency samples: 381420
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> d544ba8b7c8db5fb4bb91428992909d4690e8f76 passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> d544ba8b7c8db5fb4bb91428992909d4690e8f76

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> d544ba8b7c8db5fb4bb91428992909d4690e8f76 (PR)
Upgrade the nodes to version: d544ba8b7c8db5fb4bb91428992909d4690e8f76
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1244.65 txn/s, submitted: 1248.24 txn/s, failed submission: 3.59 txn/s, expired: 3.59 txn/s, latency: 2519.75 ms, (p50: 2300 ms, p70: 2600, p90: 4000 ms, p99: 5700 ms), latency samples: 110860
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1197.13 txn/s, submitted: 1198.71 txn/s, failed submission: 1.58 txn/s, expired: 1.58 txn/s, latency: 2596.08 ms, (p50: 2400 ms, p70: 2700, p90: 3900 ms, p99: 4900 ms), latency samples: 105960
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> d544ba8b7c8db5fb4bb91428992909d4690e8f76 passed
Upgrade the remaining nodes to version: d544ba8b7c8db5fb4bb91428992909d4690e8f76
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1114.44 txn/s, submitted: 1116.69 txn/s, failed submission: 2.25 txn/s, expired: 2.25 txn/s, latency: 2664.53 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 7200 ms), latency samples: 98920
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking