Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use runs-on runner for release images workflow #14907

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

aluon
Copy link
Contributor

@aluon aluon commented Oct 9, 2024

Description

Use runs-on for release images workflow

How Has This Been Tested?

Added a dry_run input for the workflow then ran the workflow for testing https://github.com/aptos-labs/aptos-core/actions/runs/11260314466

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 9, 2024

⏱️ 1h 11m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
dispatch_event 16m 🟩
dispatch_event 15m 🟩
check-dynamic-deps 6m 🟩🟩🟩
rust-cargo-deny 5m 🟩🟩🟩
test-target-determinator 5m 🟩
execution-performance / test-target-determinator 5m 🟩
rust-doc-tests 4m 🟩
check 4m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
fetch-last-released-docker-image-tag 2m 🟩
rust-move-tests 2m 🟩
general-lints 2m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
file_change_determinator 52s 🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 17m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@aluon aluon force-pushed the aluon/release-images-runs-on branch from 74c102e to e08bfc2 Compare October 9, 2024 17:46
@aluon aluon requested review from geekflyer and a team October 9, 2024 17:51
@aluon aluon marked this pull request as ready for review October 9, 2024 17:51
@aluon aluon requested a review from a team as a code owner October 9, 2024 17:51
@aluon aluon enabled auto-merge (squash) October 10, 2024 20:38

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on e08bfc2bf8bca2e673859dc628c89bbb39e52578

two traffics test: inner traffic : committed: 13879.98 txn/s, latency: 2865.75 ms, (p50: 2700 ms, p70: 3000, p90: 3000 ms, p99: 3600 ms), latency samples: 5277460
two traffics test : committed: 99.92 txn/s, latency: 2645.54 ms, (p50: 2400 ms, p70: 2600, p90: 2700 ms, p99: 10300 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.261, avg: 0.222", "QsPosToProposal: max: 0.315, avg: 0.268", "ConsensusProposalToOrdered: max: 0.335, avg: 0.300", "ConsensusOrderedToCommit: max: 0.468, avg: 0.450", "ConsensusProposalToCommit: max: 0.765, avg: 0.750"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.13s no progress at version 2374367 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.42s no progress at version 2374365 (avg 8.42s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on a7698900f8746b5546456146a2b4824b74ec2459 ==> e08bfc2bf8bca2e673859dc628c89bbb39e52578

Compatibility test results for a7698900f8746b5546456146a2b4824b74ec2459 ==> e08bfc2bf8bca2e673859dc628c89bbb39e52578 (PR)
1. Check liveness of validators at old version: a7698900f8746b5546456146a2b4824b74ec2459
compatibility::simple-validator-upgrade::liveness-check : committed: 12733.84 txn/s, latency: 2465.37 ms, (p50: 1800 ms, p70: 2100, p90: 2400 ms, p99: 26700 ms), latency samples: 497720
2. Upgrading first Validator to new version: e08bfc2bf8bca2e673859dc628c89bbb39e52578
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7133.80 txn/s, latency: 3962.83 ms, (p50: 4600 ms, p70: 4800, p90: 4900 ms, p99: 5000 ms), latency samples: 129900
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6195.56 txn/s, latency: 5247.10 ms, (p50: 5400 ms, p70: 5500, p90: 7200 ms, p99: 7600 ms), latency samples: 222580
3. Upgrading rest of first batch to new version: e08bfc2bf8bca2e673859dc628c89bbb39e52578
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7109.89 txn/s, latency: 3960.32 ms, (p50: 4500 ms, p70: 4700, p90: 4900 ms, p99: 5000 ms), latency samples: 130180
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7297.55 txn/s, latency: 4423.02 ms, (p50: 4700 ms, p70: 5000, p90: 5800 ms, p99: 6000 ms), latency samples: 244980
4. upgrading second batch to new version: e08bfc2bf8bca2e673859dc628c89bbb39e52578
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11948.03 txn/s, latency: 2260.72 ms, (p50: 2500 ms, p70: 2600, p90: 2700 ms, p99: 2900 ms), latency samples: 209880
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10134.39 txn/s, latency: 2973.60 ms, (p50: 2600 ms, p70: 2700, p90: 5900 ms, p99: 7900 ms), latency samples: 330880
5. check swarm health
Compatibility test for a7698900f8746b5546456146a2b4824b74ec2459 ==> e08bfc2bf8bca2e673859dc628c89bbb39e52578 passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on a7698900f8746b5546456146a2b4824b74ec2459 ==> e08bfc2bf8bca2e673859dc628c89bbb39e52578

Compatibility test results for a7698900f8746b5546456146a2b4824b74ec2459 ==> e08bfc2bf8bca2e673859dc628c89bbb39e52578 (PR)
Upgrade the nodes to version: e08bfc2bf8bca2e673859dc628c89bbb39e52578
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1272.00 txn/s, submitted: 1274.51 txn/s, failed submission: 2.51 txn/s, expired: 2.51 txn/s, latency: 2412.03 ms, (p50: 2300 ms, p70: 2700, p90: 3600 ms, p99: 5300 ms), latency samples: 111480
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1166.14 txn/s, submitted: 1168.64 txn/s, failed submission: 2.49 txn/s, expired: 2.49 txn/s, latency: 2609.79 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 6500 ms), latency samples: 102940
5. check swarm health
Compatibility test for a7698900f8746b5546456146a2b4824b74ec2459 ==> e08bfc2bf8bca2e673859dc628c89bbb39e52578 passed
Upgrade the remaining nodes to version: e08bfc2bf8bca2e673859dc628c89bbb39e52578
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1226.54 txn/s, submitted: 1228.82 txn/s, failed submission: 2.28 txn/s, expired: 2.28 txn/s, latency: 2447.94 ms, (p50: 2400 ms, p70: 2700, p90: 3500 ms, p99: 6200 ms), latency samples: 107680
Test Ok

@aluon aluon merged commit 85bba15 into main Oct 10, 2024
95 checks passed
@aluon aluon deleted the aluon/release-images-runs-on branch October 10, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants