Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add federated keyless to the rust sdk #14905

Merged
merged 12 commits into from
Oct 10, 2024

Conversation

heliuchuan
Copy link
Contributor

@heliuchuan heliuchuan commented Oct 9, 2024

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 9, 2024

⏱️ 6h 55m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 2h 42m 🟥🟩🟥🟥🟩 (+3 more)
test-target-determinator 22m 🟩🟩🟩🟩🟩
execution-performance / test-target-determinator 22m 🟩🟩🟩🟩🟩
check 19m 🟩🟩🟩🟩🟩
rust-cargo-deny 16m 🟩🟩🟩🟩🟩 (+5 more)
forge-compat-test / forge 15m 🟩
forge-framework-upgrade-test / forge 15m 🟩
check-dynamic-deps 13m 🟩🟩🟩🟩🟩 (+7 more)
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@heliuchuan heliuchuan marked this pull request as ready for review October 9, 2024 20:48
@heliuchuan heliuchuan enabled auto-merge (squash) October 10, 2024 17:06

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on a7698900f8746b5546456146a2b4824b74ec2459 ==> c58960570971117a2333a86e4b0453c96e319ddb

Compatibility test results for a7698900f8746b5546456146a2b4824b74ec2459 ==> c58960570971117a2333a86e4b0453c96e319ddb (PR)
1. Check liveness of validators at old version: a7698900f8746b5546456146a2b4824b74ec2459
compatibility::simple-validator-upgrade::liveness-check : committed: 12671.80 txn/s, latency: 2711.32 ms, (p50: 1900 ms, p70: 2100, p90: 3300 ms, p99: 22700 ms), latency samples: 497920
2. Upgrading first Validator to new version: c58960570971117a2333a86e4b0453c96e319ddb
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7617.09 txn/s, latency: 3749.11 ms, (p50: 4200 ms, p70: 4300, p90: 4500 ms, p99: 4600 ms), latency samples: 144480
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6437.71 txn/s, latency: 4662.48 ms, (p50: 4800 ms, p70: 5100, p90: 5200 ms, p99: 6200 ms), latency samples: 241220
3. Upgrading rest of first batch to new version: c58960570971117a2333a86e4b0453c96e319ddb
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7290.01 txn/s, latency: 3893.83 ms, (p50: 4400 ms, p70: 4700, p90: 4800 ms, p99: 4900 ms), latency samples: 134300
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7052.27 txn/s, latency: 4551.45 ms, (p50: 4600 ms, p70: 4700, p90: 6700 ms, p99: 6900 ms), latency samples: 234160
4. upgrading second batch to new version: c58960570971117a2333a86e4b0453c96e319ddb
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11726.01 txn/s, latency: 2290.75 ms, (p50: 2500 ms, p70: 2600, p90: 2700 ms, p99: 2800 ms), latency samples: 205180
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10020.78 txn/s, latency: 3099.81 ms, (p50: 2800 ms, p70: 2800, p90: 6200 ms, p99: 7700 ms), latency samples: 338860
5. check swarm health
Compatibility test for a7698900f8746b5546456146a2b4824b74ec2459 ==> c58960570971117a2333a86e4b0453c96e319ddb passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on c58960570971117a2333a86e4b0453c96e319ddb

two traffics test: inner traffic : committed: 13620.84 txn/s, latency: 2920.03 ms, (p50: 2700 ms, p70: 3000, p90: 3200 ms, p99: 3600 ms), latency samples: 5178980
two traffics test : committed: 99.96 txn/s, latency: 2507.19 ms, (p50: 2400 ms, p70: 2600, p90: 2800 ms, p99: 3600 ms), latency samples: 1820
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.238, avg: 0.221", "QsPosToProposal: max: 0.381, avg: 0.308", "ConsensusProposalToOrdered: max: 0.328, avg: 0.307", "ConsensusOrderedToCommit: max: 0.485, avg: 0.456", "ConsensusProposalToCommit: max: 0.795, avg: 0.762"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.03s no progress at version 2512119 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.20s no progress at version 2512117 (avg 8.20s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on a7698900f8746b5546456146a2b4824b74ec2459 ==> c58960570971117a2333a86e4b0453c96e319ddb

Compatibility test results for a7698900f8746b5546456146a2b4824b74ec2459 ==> c58960570971117a2333a86e4b0453c96e319ddb (PR)
Upgrade the nodes to version: c58960570971117a2333a86e4b0453c96e319ddb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1276.57 txn/s, submitted: 1278.39 txn/s, failed submission: 1.82 txn/s, expired: 1.82 txn/s, latency: 2449.08 ms, (p50: 2400 ms, p70: 2700, p90: 3600 ms, p99: 5400 ms), latency samples: 112160
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1302.29 txn/s, submitted: 1306.49 txn/s, failed submission: 4.20 txn/s, expired: 4.20 txn/s, latency: 2290.52 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 5400 ms), latency samples: 117800
5. check swarm health
Compatibility test for a7698900f8746b5546456146a2b4824b74ec2459 ==> c58960570971117a2333a86e4b0453c96e319ddb passed
Upgrade the remaining nodes to version: c58960570971117a2333a86e4b0453c96e319ddb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1303.53 txn/s, submitted: 1304.88 txn/s, failed submission: 1.35 txn/s, expired: 1.35 txn/s, latency: 2495.26 ms, (p50: 2300 ms, p70: 2400, p90: 4200 ms, p99: 5200 ms), latency samples: 116080
Test Ok

@heliuchuan heliuchuan merged commit a84e2be into aptos-labs:main Oct 10, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants