Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed determine-test-metadata to use current branch as default branch #14897

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

yzaccc
Copy link
Contributor

@yzaccc yzaccc commented Oct 8, 2024

Description

changed to use current branch as default branch, so the images for testing can be found correctly.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@yzaccc yzaccc requested a review from a team as a code owner October 8, 2024 21:45
Copy link

trunk-io bot commented Oct 8, 2024

⏱️ 2h 14m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
dispatch_event 16m 🟩
dispatch_event 16m 🟩
dispatch_event 15m 🟩
dispatch_event 15m 🟩
dispatch_event 14m 🟩
rust-cargo-deny 9m 🟩🟩🟩🟩🟩
check-dynamic-deps 8m 🟩🟩🟩🟩🟩 (+1 more)
determine-test-metadata 5m 🟥🟥🟩🟩
rust-doc-tests 4m 🟩
execution-performance / test-target-determinator 4m 🟩
test-target-determinator 4m 🟩
check 4m 🟩
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+1 more)
general-lints 2m 🟩🟩🟩🟩🟩
rust-move-tests 2m 🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 3m 1m +124%
execution-performance / single-node-performance 10s 17m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

.github/workflows/forge-stable.yaml Outdated Show resolved Hide resolved
@yzaccc yzaccc enabled auto-merge (squash) October 9, 2024 18:03

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

✅ Forge suite realistic_env_max_load success on fe6af6b3803ff5ba6ecf6773677e515365f97b7d

two traffics test: inner traffic : committed: 13764.10 txn/s, latency: 2888.16 ms, (p50: 2700 ms, p70: 3000, p90: 3000 ms, p99: 3600 ms), latency samples: 5233500
two traffics test : committed: 99.99 txn/s, latency: 2485.25 ms, (p50: 2400 ms, p70: 2500, p90: 2700 ms, p99: 6400 ms), latency samples: 1700
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.235, avg: 0.219", "QsPosToProposal: max: 0.346, avg: 0.285", "ConsensusProposalToOrdered: max: 0.325, avg: 0.301", "ConsensusOrderedToCommit: max: 0.494, avg: 0.460", "ConsensusProposalToCommit: max: 0.794, avg: 0.761"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.95s no progress at version 13231 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.30s no progress at version 2706385 (avg 8.30s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Oct 9, 2024

✅ Forge suite framework_upgrade success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> fe6af6b3803ff5ba6ecf6773677e515365f97b7d

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> fe6af6b3803ff5ba6ecf6773677e515365f97b7d (PR)
Upgrade the nodes to version: fe6af6b3803ff5ba6ecf6773677e515365f97b7d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1295.94 txn/s, submitted: 1297.35 txn/s, failed submission: 1.41 txn/s, expired: 1.41 txn/s, latency: 2466.64 ms, (p50: 2100 ms, p70: 2400, p90: 4200 ms, p99: 6000 ms), latency samples: 110160
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1109.02 txn/s, submitted: 1112.56 txn/s, failed submission: 3.54 txn/s, expired: 3.54 txn/s, latency: 2661.49 ms, (p50: 2400 ms, p70: 2700, p90: 4600 ms, p99: 6500 ms), latency samples: 100340
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> fe6af6b3803ff5ba6ecf6773677e515365f97b7d passed
Upgrade the remaining nodes to version: fe6af6b3803ff5ba6ecf6773677e515365f97b7d
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1290.36 txn/s, submitted: 1292.97 txn/s, failed submission: 2.61 txn/s, expired: 2.61 txn/s, latency: 2529.32 ms, (p50: 2100 ms, p70: 2400, p90: 4300 ms, p99: 5700 ms), latency samples: 108560
Test Ok

Copy link
Contributor

github-actions bot commented Oct 9, 2024

✅ Forge suite compat success on 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> fe6af6b3803ff5ba6ecf6773677e515365f97b7d

Compatibility test results for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> fe6af6b3803ff5ba6ecf6773677e515365f97b7d (PR)
1. Check liveness of validators at old version: 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775
compatibility::simple-validator-upgrade::liveness-check : committed: 12444.71 txn/s, latency: 2552.74 ms, (p50: 1900 ms, p70: 2100, p90: 5800 ms, p99: 10500 ms), latency samples: 435640
2. Upgrading first Validator to new version: fe6af6b3803ff5ba6ecf6773677e515365f97b7d
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7497.64 txn/s, latency: 3794.75 ms, (p50: 4300 ms, p70: 4500, p90: 4700 ms, p99: 4900 ms), latency samples: 137280
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6700.98 txn/s, latency: 4741.69 ms, (p50: 4800 ms, p70: 4900, p90: 7100 ms, p99: 7400 ms), latency samples: 235400
3. Upgrading rest of first batch to new version: fe6af6b3803ff5ba6ecf6773677e515365f97b7d
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6614.59 txn/s, latency: 4000.51 ms, (p50: 4400 ms, p70: 4700, p90: 5000 ms, p99: 5200 ms), latency samples: 139540
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7084.70 txn/s, latency: 4517.84 ms, (p50: 4700 ms, p70: 4900, p90: 6700 ms, p99: 6900 ms), latency samples: 239280
4. upgrading second batch to new version: fe6af6b3803ff5ba6ecf6773677e515365f97b7d
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9278.69 txn/s, latency: 2897.29 ms, (p50: 3000 ms, p70: 3400, p90: 3700 ms, p99: 3900 ms), latency samples: 172720
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9663.41 txn/s, latency: 3258.14 ms, (p50: 2900 ms, p70: 3100, p90: 6100 ms, p99: 8700 ms), latency samples: 365660
5. check swarm health
Compatibility test for 46bf19eb4f132b9d8fc19eff3f3334cdf9aa1775 ==> fe6af6b3803ff5ba6ecf6773677e515365f97b7d passed
Test Ok

@yzaccc yzaccc merged commit d62bef5 into main Oct 9, 2024
112 checks passed
@yzaccc yzaccc deleted the yzaccc/fix-forge-stable branch October 9, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants