[compiler-v2] Add loop labels to the language #14868

wrwg · 2024-10-04T06:58:31Z

Description

Besides the user being able to describe complex algorithms more efficiently, loop labels are required to express aribtrary reducible control flow graphs in the AST language, and create parity of the AST with the bytecode level for this kind of code (which is also what can be generated from Move).

How Has This Been Tested?

New baseline tests in checking, v1-checking, bytecode generation, and a transactional test.

Type of Change

Which Components or Systems Does This Change Impact?

trunk-io · 2024-10-04T06:58:35Z

⏱️ 4h 44m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
execution-performance / single-node-performance	21m	🟩
rust-move-unit-coverage	16m	🟩
dispatch_event	16m	🟩
rust-move-unit-coverage	16m	🟩
rust-move-unit-coverage	16m	🟩
dispatch_event	15m	🟩
dispatch_event	15m	🟩
rust-move-unit-coverage	15m	🟩
dispatch_event	14m	🟩
rust-cargo-deny	12m	🟩 🟩 🟩 ⬜ 🟩 (+3 more)
rust-move-unit-coverage	11m	🟩
rust-move-unit-coverage	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

wrwg · 2024-10-04T06:58:48Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wrwg and the rest of your teammates on Graphite

codecov · 2024-10-04T07:14:25Z

Codecov Report

Attention: Patch coverage is 73.29193% with 43 lines in your changes missing coverage. Please review.

Project coverage is 60.1%. Comparing base (a822e65) to head (d1e567a).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...hird_party/move/move-compiler/src/expansion/ast.rs	0.0%	18 Missing ⚠️
third_party/move/move-compiler/src/parser/ast.rs	0.0%	18 Missing ⚠️
third_party/move/move-model/src/lib.rs	0.0%	4 Missing ⚠️
...arty/move/move-compiler/src/expansion/translate.rs	66.6%	2 Missing ⚠️
third_party/move/move-compiler/src/parser/lexer.rs	90.9%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #14868    +/-   ##
========================================
  Coverage    60.0%    60.1%            
========================================
  Files         856      856            
  Lines      210892   211013   +121     
========================================
+ Hits       126742   126824    +82     
- Misses      84150    84189    +39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vineethk

Looking pretty good! I have a few comments, but should be ready to go once they are addressed.

third_party/move/move-compiler/src/parser/syntax.rs

third_party/move/move-compiler/src/parser/lexer.rs

wrwg

Thanks for the review!

third_party/move/move-compiler/src/parser/syntax.rs

vineethk

Looks good, have one comment to be addressed.

third_party/move/move-compiler/src/parser/lexer.rs

third_party/move/move-compiler/src/parser/syntax.rs

wrwg

Comments addressed, thanks for the review!

third_party/move/move-compiler/src/parser/lexer.rs

Besides the user being able to describe more complex algorithms more efficiently, loop labels are required to express any reducible control flow in the AST language, and create parity of the AST with the bytecode level for this kind of code (which is also what can be generated from Move).

github-actions · 2024-10-11T18:36:25Z

✅ Forge suite `compat` success on `beff51858b445401e49d5be352feadcf05652cc0` ==> `d1e567aadd52708476b0c192569c1510274ab0c9`

Compatibility test results for beff51858b445401e49d5be352feadcf05652cc0 ==> d1e567aadd52708476b0c192569c1510274ab0c9 (PR)
1. Check liveness of validators at old version: beff51858b445401e49d5be352feadcf05652cc0
compatibility::simple-validator-upgrade::liveness-check : committed: 11480.77 txn/s, latency: 2809.69 ms, (p50: 2100 ms, p70: 2400, p90: 6300 ms, p99: 16100 ms), latency samples: 391900
2. Upgrading first Validator to new version: d1e567aadd52708476b0c192569c1510274ab0c9
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 5145.43 txn/s, latency: 5593.56 ms, (p50: 6300 ms, p70: 6900, p90: 7600 ms, p99: 7900 ms), latency samples: 100000
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5504.46 txn/s, latency: 5898.21 ms, (p50: 6400 ms, p70: 6700, p90: 7300 ms, p99: 8000 ms), latency samples: 191460
3. Upgrading rest of first batch to new version: d1e567aadd52708476b0c192569c1510274ab0c9
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6759.89 txn/s, latency: 4230.44 ms, (p50: 4900 ms, p70: 5100, p90: 5300 ms, p99: 5400 ms), latency samples: 120300
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7167.46 txn/s, latency: 4534.12 ms, (p50: 5000 ms, p70: 5100, p90: 5200 ms, p99: 5300 ms), latency samples: 240660
4. upgrading second batch to new version: d1e567aadd52708476b0c192569c1510274ab0c9
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11756.34 txn/s, latency: 2305.10 ms, (p50: 2400 ms, p70: 2600, p90: 2800 ms, p99: 2900 ms), latency samples: 203840
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10431.59 txn/s, latency: 2965.72 ms, (p50: 2600 ms, p70: 2800, p90: 6000 ms, p99: 7000 ms), latency samples: 339980
5. check swarm health
Compatibility test for beff51858b445401e49d5be352feadcf05652cc0 ==> d1e567aadd52708476b0c192569c1510274ab0c9 passed
Test Ok

github-actions · 2024-10-11T18:37:13Z

✅ Forge suite `realistic_env_max_load` success on `d1e567aadd52708476b0c192569c1510274ab0c9`

two traffics test: inner traffic : committed: 13157.16 txn/s, latency: 3022.67 ms, (p50: 3000 ms, p70: 3000, p90: 3300 ms, p99: 6300 ms), latency samples: 5002660
two traffics test : committed: 100.05 txn/s, latency: 2651.66 ms, (p50: 2500 ms, p70: 2700, p90: 2900 ms, p99: 5500 ms), latency samples: 1700
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.264, avg: 0.225", "QsPosToProposal: max: 0.287, avg: 0.227", "ConsensusProposalToOrdered: max: 0.336, avg: 0.304", "ConsensusOrderedToCommit: max: 0.508, avg: 0.470", "ConsensusProposalToCommit: max: 0.810, avg: 0.774"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.84s no progress at version 3999340 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.00s no progress at version 3999338 (avg 4.30s) [limit 15].
Test Ok

github-actions · 2024-10-11T18:40:20Z

✅ Forge suite `framework_upgrade` success on `beff51858b445401e49d5be352feadcf05652cc0` ==> `d1e567aadd52708476b0c192569c1510274ab0c9`

Compatibility test results for beff51858b445401e49d5be352feadcf05652cc0 ==> d1e567aadd52708476b0c192569c1510274ab0c9 (PR)
Upgrade the nodes to version: d1e567aadd52708476b0c192569c1510274ab0c9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1134.31 txn/s, submitted: 1136.76 txn/s, failed submission: 2.46 txn/s, expired: 2.46 txn/s, latency: 2783.13 ms, (p50: 2400 ms, p70: 2900, p90: 4500 ms, p99: 6000 ms), latency samples: 101600
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1120.94 txn/s, submitted: 1122.96 txn/s, failed submission: 2.02 txn/s, expired: 2.02 txn/s, latency: 2754.40 ms, (p50: 2400 ms, p70: 3000, p90: 4800 ms, p99: 5900 ms), latency samples: 99820
5. check swarm health
Compatibility test for beff51858b445401e49d5be352feadcf05652cc0 ==> d1e567aadd52708476b0c192569c1510274ab0c9 passed
Upgrade the remaining nodes to version: d1e567aadd52708476b0c192569c1510274ab0c9
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1288.98 txn/s, submitted: 1291.30 txn/s, failed submission: 2.32 txn/s, expired: 2.32 txn/s, latency: 2739.56 ms, (p50: 2100 ms, p70: 3000, p90: 5100 ms, p99: 7400 ms), latency samples: 100000
Test Ok

wrwg mentioned this pull request Oct 4, 2024

[compiler-v2][decompiler] Pulling fat-loop algorithm out of the prover #14488

Merged

15 tasks

wrwg mentioned this pull request Oct 4, 2024

[compiler-v2] Ast generator from stackless bytecode, Source Gen from Ast #14494

Merged

15 tasks

wrwg requested review from brmataptos, rahxephon89 and vineethk October 4, 2024 07:04

vineethk reviewed Oct 6, 2024

View reviewed changes

wrwg force-pushed the wrwg/astifier branch from b55b1c3 to 867fce7 Compare October 8, 2024 05:25

wrwg force-pushed the wrwg/loop-labels branch from c24ecf7 to 8990356 Compare October 8, 2024 05:25

wrwg force-pushed the wrwg/astifier branch 3 times, most recently from 4352c47 to ae2049a Compare October 9, 2024 02:49

wrwg force-pushed the wrwg/loop-labels branch from 116fb63 to ffc69a0 Compare October 9, 2024 02:50

wrwg commented Oct 9, 2024

View reviewed changes

third_party/move/move-compiler/src/parser/syntax.rs Show resolved Hide resolved

third_party/move/move-compiler/src/parser/syntax.rs Show resolved Hide resolved

wrwg requested a review from vineethk October 9, 2024 02:51

wrwg force-pushed the wrwg/astifier branch from ae2049a to 11cc61f Compare October 9, 2024 03:56

Base automatically changed from wrwg/astifier to main October 9, 2024 04:27

wrwg force-pushed the wrwg/loop-labels branch 2 times, most recently from e50a64b to d134193 Compare October 9, 2024 06:01

vineethk approved these changes Oct 9, 2024

View reviewed changes

third_party/move/move-compiler/src/parser/lexer.rs Show resolved Hide resolved

brmataptos reviewed Oct 10, 2024

View reviewed changes

third_party/move/move-compiler/src/parser/syntax.rs Outdated Show resolved Hide resolved

wrwg commented Oct 11, 2024

View reviewed changes

third_party/move/move-compiler/src/parser/lexer.rs Show resolved Hide resolved

wrwg requested a review from brmataptos October 11, 2024 03:40

wrwg force-pushed the wrwg/loop-labels branch from cb2f2e1 to 9ca62ec Compare October 11, 2024 03:42

wrwg enabled auto-merge (squash) October 11, 2024 03:43

This comment has been minimized.

Sign in to view

wrwg and others added 3 commits October 11, 2024 11:06

Apply suggestions from code review

6612dc5

Addressing reviewer comments.

d1e567a

wrwg force-pushed the wrwg/loop-labels branch from 9ca62ec to d1e567a Compare October 11, 2024 18:06

This comment has been minimized.

Sign in to view

brmataptos approved these changes Oct 11, 2024

View reviewed changes

wrwg merged commit 55e368c into main Oct 11, 2024
50 checks passed

wrwg deleted the wrwg/loop-labels branch October 11, 2024 18:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[compiler-v2] Add loop labels to the language #14868

[compiler-v2] Add loop labels to the language #14868

wrwg commented Oct 4, 2024

trunk-io bot commented Oct 4, 2024 •

edited

Loading

wrwg commented Oct 4, 2024 •

edited

Loading

codecov bot commented Oct 4, 2024 •

edited

Loading

vineethk left a comment

wrwg left a comment

vineethk left a comment

wrwg left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 11, 2024

github-actions bot commented Oct 11, 2024

github-actions bot commented Oct 11, 2024

[compiler-v2] Add loop labels to the language #14868

[compiler-v2] Add loop labels to the language #14868

Conversation

wrwg commented Oct 4, 2024

Description

How Has This Been Tested?

Type of Change

Which Components or Systems Does This Change Impact?

trunk-io bot commented Oct 4, 2024 • edited Loading

wrwg commented Oct 4, 2024 • edited Loading

codecov bot commented Oct 4, 2024 • edited Loading

Codecov Report

vineethk left a comment

Choose a reason for hiding this comment

wrwg left a comment

Choose a reason for hiding this comment

vineethk left a comment

Choose a reason for hiding this comment

wrwg left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Oct 11, 2024

✅ Forge suite compat success on beff51858b445401e49d5be352feadcf05652cc0 ==> d1e567aadd52708476b0c192569c1510274ab0c9

github-actions bot commented Oct 11, 2024

✅ Forge suite realistic_env_max_load success on d1e567aadd52708476b0c192569c1510274ab0c9

github-actions bot commented Oct 11, 2024

✅ Forge suite framework_upgrade success on beff51858b445401e49d5be352feadcf05652cc0 ==> d1e567aadd52708476b0c192569c1510274ab0c9

trunk-io bot commented Oct 4, 2024 •

edited

Loading

wrwg commented Oct 4, 2024 •

edited

Loading

codecov bot commented Oct 4, 2024 •

edited

Loading

✅ Forge suite `compat` success on `beff51858b445401e49d5be352feadcf05652cc0` ==> `d1e567aadd52708476b0c192569c1510274ab0c9`

✅ Forge suite `realistic_env_max_load` success on `d1e567aadd52708476b0c192569c1510274ab0c9`

✅ Forge suite `framework_upgrade` success on `beff51858b445401e49d5be352feadcf05652cc0` ==> `d1e567aadd52708476b0c192569c1510274ab0c9`