-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cp][aptos-release-v1.21] [qs] tolerate block timestamp being updated asynchronously #14864
Merged
zekun000
merged 1 commit into
aptos-release-v1.21
from
backport/aptos-release-v1.21/pr-14861
Oct 4, 2024
Merged
[cp][aptos-release-v1.21] [qs] tolerate block timestamp being updated asynchronously #14864
zekun000
merged 1 commit into
aptos-release-v1.21
from
backport/aptos-release-v1.21/pr-14861
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous commit, we move timestamp update to async callback to ensure the consistency between mempool, qs and consensus. However it introduces the race of timestamp can be updated by sync_to first then async callback and violates the assertion. (cherry picked from commit 41e82f7)
github-actions
bot
requested review from
bchocho,
sasha8 and
gelash
as code owners
October 3, 2024 22:14
⏱️ 49m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
ibalajiarun
approved these changes
Oct 4, 2024
zekun000
approved these changes
Oct 4, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
main
toaptos-release-v1.21
:Questions ?
Please refer to the Backport tool documentation