Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consensus] batch availability counters for InlineHybrid payload #14853

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

ibalajiarun
Copy link
Contributor

Description

Counters to track the local availability of batches when a proposal is received.

Copy link

trunk-io bot commented Oct 2, 2024

⏱️ 30m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-doc-tests 5m 🟩
test-target-determinator 4m 🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
rust-cargo-deny 3m 🟩🟩
check-dynamic-deps 2m 🟩🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
fetch-last-released-docker-image-tag 1m 🟩
semgrep/ci 1m 🟩🟩🟩
general-lints 47s 🟩🟩
file_change_determinator 15s 🟩🟩
file_change_determinator 12s 🟩
execution-performance / single-node-performance 10s 🟩
permission-check 8s 🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 17m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Oct 2, 2024

✅ Forge suite compat success on e8a6faf60a98afca8982e0582f929401294bbd33 ==> b7bd93d31203fdcb3acccbd064b6c3f531fe218f

Compatibility test results for e8a6faf60a98afca8982e0582f929401294bbd33 ==> b7bd93d31203fdcb3acccbd064b6c3f531fe218f (PR)
1. Check liveness of validators at old version: e8a6faf60a98afca8982e0582f929401294bbd33
compatibility::simple-validator-upgrade::liveness-check : committed: 7660.69 txn/s, latency: 3882.24 ms, (p50: 2200 ms, p70: 2700, p90: 11500 ms, p99: 15100 ms), latency samples: 297140
2. Upgrading first Validator to new version: b7bd93d31203fdcb3acccbd064b6c3f531fe218f
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7349.24 txn/s, latency: 3869.79 ms, (p50: 4300 ms, p70: 4600, p90: 4800 ms, p99: 4900 ms), latency samples: 136960
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6545.84 txn/s, latency: 4546.41 ms, (p50: 4700 ms, p70: 4800, p90: 5000 ms, p99: 6300 ms), latency samples: 249480
3. Upgrading rest of first batch to new version: b7bd93d31203fdcb3acccbd064b6c3f531fe218f
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6333.38 txn/s, latency: 4463.36 ms, (p50: 5100 ms, p70: 5400, p90: 5600 ms, p99: 5700 ms), latency samples: 115520
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6111.81 txn/s, latency: 5164.44 ms, (p50: 5400 ms, p70: 5500, p90: 7200 ms, p99: 7400 ms), latency samples: 232280
4. upgrading second batch to new version: b7bd93d31203fdcb3acccbd064b6c3f531fe218f
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 6672.51 txn/s, latency: 4084.77 ms, (p50: 3200 ms, p70: 5800, p90: 7700 ms, p99: 8200 ms), latency samples: 120320
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6651.98 txn/s, latency: 4253.71 ms, (p50: 3400 ms, p70: 4200, p90: 10000 ms, p99: 14800 ms), latency samples: 273160
5. check swarm health
Compatibility test for e8a6faf60a98afca8982e0582f929401294bbd33 ==> b7bd93d31203fdcb3acccbd064b6c3f531fe218f passed
Test Ok

Copy link
Contributor

github-actions bot commented Oct 2, 2024

✅ Forge suite realistic_env_max_load success on b7bd93d31203fdcb3acccbd064b6c3f531fe218f

two traffics test: inner traffic : committed: 11624.28 txn/s, latency: 3423.97 ms, (p50: 3000 ms, p70: 3600, p90: 4400 ms, p99: 8700 ms), latency samples: 4419820
two traffics test : committed: 100.03 txn/s, latency: 3070.64 ms, (p50: 2500 ms, p70: 3200, p90: 4100 ms, p99: 11600 ms), latency samples: 1660
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.243, avg: 0.222", "QsPosToProposal: max: 0.609, avg: 0.376", "ConsensusProposalToOrdered: max: 0.334, avg: 0.320", "ConsensusOrderedToCommit: max: 0.543, avg: 0.473", "ConsensusProposalToCommit: max: 0.874, avg: 0.793"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.98s no progress at version 12680 (avg 0.23s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 7.14s no progress at version 1759871 (avg 5.64s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Oct 2, 2024

✅ Forge suite framework_upgrade success on e8a6faf60a98afca8982e0582f929401294bbd33 ==> b7bd93d31203fdcb3acccbd064b6c3f531fe218f

Compatibility test results for e8a6faf60a98afca8982e0582f929401294bbd33 ==> b7bd93d31203fdcb3acccbd064b6c3f531fe218f (PR)
Upgrade the nodes to version: b7bd93d31203fdcb3acccbd064b6c3f531fe218f
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1190.63 txn/s, submitted: 1192.65 txn/s, failed submission: 2.02 txn/s, expired: 2.02 txn/s, latency: 2541.02 ms, (p50: 2400 ms, p70: 2700, p90: 3600 ms, p99: 5400 ms), latency samples: 106340
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1203.48 txn/s, submitted: 1206.12 txn/s, failed submission: 2.64 txn/s, expired: 2.64 txn/s, latency: 2465.51 ms, (p50: 2100 ms, p70: 2400, p90: 4200 ms, p99: 5800 ms), latency samples: 109400
5. check swarm health
Compatibility test for e8a6faf60a98afca8982e0582f929401294bbd33 ==> b7bd93d31203fdcb3acccbd064b6c3f531fe218f passed
Upgrade the remaining nodes to version: b7bd93d31203fdcb3acccbd064b6c3f531fe218f
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 670.19 txn/s, submitted: 672.08 txn/s, failed submission: 1.89 txn/s, expired: 1.89 txn/s, latency: 4805.40 ms, (p50: 4600 ms, p70: 6600, p90: 8400 ms, p99: 10200 ms), latency samples: 56660
Test Ok

@ibalajiarun ibalajiarun merged commit 1c97501 into main Oct 2, 2024
81 of 82 checks passed
@ibalajiarun ibalajiarun deleted the balaji/optqs-measure branch October 2, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants