Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gha] remove unused indexer tests #14852

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

rustielin
Copy link
Contributor

@rustielin rustielin commented Oct 2, 2024

Description

This PR removes the indexer grpc integration test and docker e2e tests from running on the main branch.

Notably, it keeps the docker e2e test workflow definition around, despite it not being used from the main branch. This is because other branches that do not the changes in the docker-build-test.yaml that this PR introduces will continue to reference the docker e2e test via .github/workflows/docker-indexer-grpc-test.yaml@main. This prevents errors such as this: https://github.com/aptos-labs/aptos-core/actions/runs/11151838164

image

The indexer grpc integration test workflow can be safely deleted as it is not being used as a reusable workflow anywhere, but instead triggers on pull_request

How Has This Been Tested?

CI

Key Areas to Review

The behavior of GHA when referencing reusable workflows by git ref

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@rustielin rustielin requested a review from a team as a code owner October 2, 2024 22:50
Copy link

trunk-io bot commented Oct 2, 2024

⏱️ 31m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-doc-tests 5m 🟩
test-target-determinator 4m 🟩
execution-performance / test-target-determinator 4m 🟩
check 4m 🟩
rust-cargo-deny 3m 🟩🟩
check-dynamic-deps 3m 🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
fetch-last-released-docker-image-tag 2m 🟩
general-lints 55s 🟩🟩
semgrep/ci 44s 🟩🟩
file_change_determinator 24s 🟩🟩
execution-performance / single-node-performance 11s 🟩
file_change_determinator 10s 🟩
permission-check 10s 🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 11s 17m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@rustielin rustielin requested review from ibalajiarun, sionescu, bchocho, larry-aptos and a team and removed request for a team October 2, 2024 22:50
@rustielin rustielin enabled auto-merge (squash) October 3, 2024 01:46

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

✅ Forge suite compat success on e8a6faf60a98afca8982e0582f929401294bbd33 ==> 654065fdad5b62a836da76966fc5bf28f73c4e44

Compatibility test results for e8a6faf60a98afca8982e0582f929401294bbd33 ==> 654065fdad5b62a836da76966fc5bf28f73c4e44 (PR)
1. Check liveness of validators at old version: e8a6faf60a98afca8982e0582f929401294bbd33
compatibility::simple-validator-upgrade::liveness-check : committed: 13253.08 txn/s, latency: 2457.15 ms, (p50: 1900 ms, p70: 2200, p90: 4600 ms, p99: 13300 ms), latency samples: 455260
2. Upgrading first Validator to new version: 654065fdad5b62a836da76966fc5bf28f73c4e44
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6816.61 txn/s, latency: 4146.50 ms, (p50: 4400 ms, p70: 4700, p90: 5500 ms, p99: 5700 ms), latency samples: 145100
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7134.39 txn/s, latency: 4496.49 ms, (p50: 4700 ms, p70: 4900, p90: 6500 ms, p99: 7000 ms), latency samples: 241380
3. Upgrading rest of first batch to new version: 654065fdad5b62a836da76966fc5bf28f73c4e44
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 5902.39 txn/s, latency: 4848.62 ms, (p50: 5500 ms, p70: 5800, p90: 6000 ms, p99: 6100 ms), latency samples: 113400
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5372.85 txn/s, latency: 5629.19 ms, (p50: 6000 ms, p70: 6200, p90: 6400 ms, p99: 6900 ms), latency samples: 199920
4. upgrading second batch to new version: 654065fdad5b62a836da76966fc5bf28f73c4e44
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10215.45 txn/s, latency: 2668.56 ms, (p50: 2700 ms, p70: 3000, p90: 3200 ms, p99: 4500 ms), latency samples: 180900
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10979.41 txn/s, latency: 2795.51 ms, (p50: 2700 ms, p70: 2900, p90: 3200 ms, p99: 3300 ms), latency samples: 362760
5. check swarm health
Compatibility test for e8a6faf60a98afca8982e0582f929401294bbd33 ==> 654065fdad5b62a836da76966fc5bf28f73c4e44 passed
Test Ok

Copy link
Contributor

github-actions bot commented Oct 3, 2024

✅ Forge suite realistic_env_max_load success on 654065fdad5b62a836da76966fc5bf28f73c4e44

two traffics test: inner traffic : committed: 13681.48 txn/s, latency: 2905.58 ms, (p50: 2700 ms, p70: 3000, p90: 3000 ms, p99: 3600 ms), latency samples: 5202060
two traffics test : committed: 99.92 txn/s, latency: 2561.02 ms, (p50: 2400 ms, p70: 2600, p90: 2800 ms, p99: 6400 ms), latency samples: 1680
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.233, avg: 0.220", "QsPosToProposal: max: 0.293, avg: 0.237", "ConsensusProposalToOrdered: max: 0.319, avg: 0.298", "ConsensusOrderedToCommit: max: 0.485, avg: 0.472", "ConsensusProposalToCommit: max: 0.783, avg: 0.770"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.13s no progress at version 50814 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.48s no progress at version 2126532 (avg 8.48s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Oct 3, 2024

✅ Forge suite framework_upgrade success on e8a6faf60a98afca8982e0582f929401294bbd33 ==> 654065fdad5b62a836da76966fc5bf28f73c4e44

Compatibility test results for e8a6faf60a98afca8982e0582f929401294bbd33 ==> 654065fdad5b62a836da76966fc5bf28f73c4e44 (PR)
Upgrade the nodes to version: 654065fdad5b62a836da76966fc5bf28f73c4e44
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1256.74 txn/s, submitted: 1260.52 txn/s, failed submission: 3.78 txn/s, expired: 3.78 txn/s, latency: 2432.07 ms, (p50: 2400 ms, p70: 2700, p90: 3600 ms, p99: 4900 ms), latency samples: 112980
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1213.17 txn/s, submitted: 1215.38 txn/s, failed submission: 2.21 txn/s, expired: 2.21 txn/s, latency: 2567.27 ms, (p50: 2400 ms, p70: 2700, p90: 4000 ms, p99: 5400 ms), latency samples: 109560
5. check swarm health
Compatibility test for e8a6faf60a98afca8982e0582f929401294bbd33 ==> 654065fdad5b62a836da76966fc5bf28f73c4e44 passed
Upgrade the remaining nodes to version: 654065fdad5b62a836da76966fc5bf28f73c4e44
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1351.97 txn/s, submitted: 1354.27 txn/s, failed submission: 2.31 txn/s, expired: 2.31 txn/s, latency: 2563.47 ms, (p50: 2400 ms, p70: 2700, p90: 3900 ms, p99: 5700 ms), latency samples: 105460
Test Ok

@rustielin rustielin merged commit 295e362 into main Oct 3, 2024
95 checks passed
@rustielin rustielin deleted the rustielin/remove-unused-indexer-tests-2 branch October 3, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants