-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gha] remove unused indexer tests #14852
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 31m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
rustielin
requested review from
ibalajiarun,
sionescu,
bchocho,
larry-aptos and
a team
and removed request for
a team
October 2, 2024 22:50
larry-aptos
approved these changes
Oct 2, 2024
sionescu
approved these changes
Oct 2, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the indexer grpc integration test and docker e2e tests from running on the
main
branch.Notably, it keeps the docker e2e test workflow definition around, despite it not being used from the
main
branch. This is because other branches that do not the changes in thedocker-build-test.yaml
that this PR introduces will continue to reference the docker e2e test via.github/workflows/docker-indexer-grpc-test.yaml@main
. This prevents errors such as this: https://github.com/aptos-labs/aptos-core/actions/runs/11151838164The indexer grpc integration test workflow can be safely deleted as it is not being used as a reusable workflow anywhere, but instead triggers on
pull_request
How Has This Been Tested?
CI
Key Areas to Review
The behavior of GHA when referencing reusable workflows by git ref
Type of Change
Which Components or Systems Does This Change Impact?
Checklist